Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to hyperlinked titles #2

Closed
wants to merge 1 commit into from

Conversation

Dhruvi16
Copy link

No description provided.

@Dhruvi16
Copy link
Author

Dhruvi16 commented Aug 30, 2018

Resolving issue #1

@ajayns
Copy link
Collaborator

ajayns commented Aug 30, 2018

You can mention which issue you are resolving with a PR like this:
#1

That way it gets mentioned in the issue and the issue will automatically close when this is merged.

Copy link
Collaborator

@ajayns ajayns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the changes I suggested and I'll merge it :)

README.md Outdated
- [https://opensource.guide/](https://opensource.guide/)
- [https://codeburst.io/what-is-open-source-and-why-is-it-so-popular-5f6b0eaf819a](https://codeburst.io/what-is-open-source-and-why-is-it-so-popular-5f6b0eaf819a)
- [A bumpy journey through the world of open source](https://medium.freecodecamp.org/a-beginners-very-bumpy-journey-through-the-world-of-open-source-4d108d540b39) - A beginner's tale
- [Hackerearth](https://www.hackerearth.com/getstarted-opensource/) - Get started with open source
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a good job! But you may have gotten the idea a bit wrong. The titles of the articles are what matter not the publisher.

For instance, it should be:
Get started with open source
Not:
Hackerearth - Get started with open source

In case of ambiguity you can even add (not actually necessary):
Get started with open source - Hackerearth

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it.

Update links to hyperlinked titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants