Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Deployment scripts for Base chain #24

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Conversation

Sabnock01
Copy link
Member

This PR updates the Curta deployment scripts in preparation for Base deployment.

  • Deprecate DeployConstellation.s.sol
  • Remove DeployTest.s.sol which isn't used anywhere
  • Adds scripts DeployBaseGoerli.s.sol and DeployBaseMainnet.s.sol

Pending decisions:

  • Who should the owner of the contracts be on Base?
  • Which, if any, AuthorshipTokens should be minted upon deploy?

@Sabnock01 Sabnock01 marked this pull request as ready for review November 4, 2023 14:11
Copy link
Member

@fiveoutofnine fiveoutofnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I think we can delete the part about constellation here:

This project uses [**Foundry**](https://github.com/foundry-rs/foundry) as its development/testing framework and a [**Constellation**](https://constellation.so/) roll-up for testing.

and fix the file path here:

curta/README.md

Lines 161 to 164 in 9a47257

If you are deploying to the Constellation roll-up, remove `--verify` and add `--legacy`:
```sh
forge script script/deploy/DeployConstellation.s.sol:DeployConstellation -f constellation --broadcast --legacy --sender $SENDER_ADDRESS
```

@Sabnock01 Sabnock01 merged commit 4117817 into main Nov 6, 2023
2 checks passed
@Sabnock01 Sabnock01 deleted the Sabnock01/base-deployment branch November 6, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants