Fix darkmode switcher styling #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martinsos
approved these changes
Aug 30, 2024
|
@Martinsos I tried to extract code where it seemed useful. What do you think about it now? |
Martinsos
approved these changes
Sep 2, 2024
|
@vincanger looking good, I approved! I maybe wouldn't make it so that Mode compnoent takes moon and sun icons as props, but would just use them directly in it, since it seems like a bit much customization, but it doesn't hurt also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #260 -- Darkmode switcher duration styling issue
Contributor Checklist