Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up InstrEncoder::encode_branch_{nez,eqz} methods #1229

Merged
merged 18 commits into from
Oct 7, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Oct 7, 2024

No description provided.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 87.90850% with 37 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (bd735a0) to head (8c9c57e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rates/wasmi/src/engine/translator/instr_encoder.rs 81.08% 28 Missing ⚠️
crates/wasmi/src/engine/translator/comparator.rs 94.30% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
+ Coverage   81.50%   81.64%   +0.13%     
==========================================
  Files         303      304       +1     
  Lines       25008    25111     +103     
==========================================
+ Hits        20384    20501     +117     
+ Misses       4624     4610      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 66075b9 into main Oct 7, 2024
18 of 19 checks passed
@Robbepop Robbepop deleted the rf-clean-up-encode-branch-cmp branch October 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant