Configure docker for development #465
Conversation
Configured docker image to be usable for development. Also fixed the image and locked base images versions to prevent future errors.
I've realized it looks poorly with tab width shorter than 5.
|
Something jebło. |
| @@ -17,6 +17,7 @@ Django-based application to manage registration of people for [scientific summer | |||
| - `./manage.py populate_with_test_data` - script to populate the database with data for development | |||
|
|
|||
| ### Run: | |||
| - install postgresql | |||
There was a problem hiding this comment.
only in production deployments - for development, sqlite is used instead
There was a problem hiding this comment.
For me pip install -r requirements.txt failed because of missing pg_config executable.
There was a problem hiding this comment.
A @krzys-h has said, postgress should not be required for development. requirements.txt file should be adjusted if it is there
There was a problem hiding this comment.
You can create a requirements.txt file for production
| export DJANGO_SUPERUSER_PASSWORD=admin \ | ||
| export DJANGO_SUPERUSER_USERNAME=admin | ||
| # This will fail if admin user already exists. | ||
| python3 manage.py createsuperuser --noinput || true |
There was a problem hiding this comment.
This is problematic. What if I remove/rename the initial user after creating my own account?
I know this is only for development Docker, but...
There was a problem hiding this comment.
What problem do you have in mind? Can you elaborate?
There was a problem hiding this comment.
It becomes impossible to remove/change username of the default user, as it will get recreated when the container restarts. If you really want automatic user creation, it should only occur once, when the database is first created.
But personally I don't think this is necessary at all... If you want a development setup, call populate_with_test_data after starting the container which creates the admin account too iirc, if you want a production setup, don't use admin as the password...
| @@ -17,6 +17,7 @@ Django-based application to manage registration of people for [scientific summer | |||
| - `./manage.py populate_with_test_data` - script to populate the database with data for development | |||
|
|
|||
| ### Run: | |||
| - install postgresql | |||
There was a problem hiding this comment.
A @krzys-h has said, postgress should not be required for development. requirements.txt file should be adjusted if it is there
| @@ -17,6 +17,7 @@ Django-based application to manage registration of people for [scientific summer | |||
| - `./manage.py populate_with_test_data` - script to populate the database with data for development | |||
|
|
|||
| ### Run: | |||
| - install postgresql | |||
There was a problem hiding this comment.
You can create a requirements.txt file for production
| @@ -0,0 +1,6 @@ | |||
| coverage==5.5 | |||
There was a problem hiding this comment.
You probably need to update CI so it properly installs this requirements for running tests
There was a problem hiding this comment.
He already did - the tests fail for a different reason, the same fail message is in the other PR which doesn't touch requirements
Configured docker image to be usable for development.
Also fixed the image and locked base images versions to prevent future errors.
This change is