fix: simple backoff strategy after 3 subscribe failures #1238

chaitanyaprem · 2024-10-03T07:22:11Z

Description

Fixes status-im/status-go#5679 where due to DNS failure, filter subscribe loop is going into infinite loop leading to log flooding.

Added a errorCount which is incremented in case of error that requires a backoff such as "no suitable peers found" . As of now the backoff is fixed and not exponential.

waku/v2/api/filter/filter.go

waku/v2/utils/peer.go

chaitanyaprem requested review from plopezlpz and kaichaosun October 3, 2024 07:22

chaitanyaprem requested a review from richard-ramos as a code owner October 3, 2024 07:22

github-actions bot assigned chaitanyaprem Oct 3, 2024

richard-ramos approved these changes Oct 3, 2024

View reviewed changes

waku/v2/api/filter/filter.go Outdated Show resolved Hide resolved

waku/v2/utils/peer.go Show resolved Hide resolved

chaitanyaprem force-pushed the fix/filter-loop branch from de47d73 to b74e4cc Compare October 4, 2024 05:31

fix: simple backoff strategy after 3 subscribe failures

7a4795b

chaitanyaprem force-pushed the fix/filter-loop branch from 1cdb557 to 7a4795b Compare October 4, 2024 05:32

chaitanyaprem merged commit 0ed94ce into master Oct 4, 2024
12 checks passed

chaitanyaprem deleted the fix/filter-loop branch October 4, 2024 05:40