feat: storenode cycle #1223
Open
feat: storenode cycle #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
force-pushed
the
storenode-cycle
branch
from
d9361e5
to
3988fc6
Compare
kaichaosun
reviewed
Sep 25, 2024
| s.Lock() | ||
| defer s.Unlock() | ||
|
|
||
| for _, subs := range s.subscriptions { |
| m.host = h | ||
| m.failedRequests = make(map[peer.ID]uint) | ||
| m.peers = make(map[peer.ID]peerStatus) | ||
|
|
There was a problem hiding this comment.
Should we connect the store node first with some strategy before actually verify the status?
| } else { | ||
| m.peers[m.activeStorenode] = peerStatus{ | ||
| status: disconnected, | ||
| canConnectAfter: time.Now().Add(backoffDuration), |
There was a problem hiding this comment.
Another strategy is have a blacklist of unreachable store nodes, and periodically check if the node should be kept in the list.
| m.logger.Info("Automatically switching storenode") | ||
|
|
||
| if m.activeStorenode != "" { | ||
| m.disconnectActiveStorenode(graylistBackoff) |
There was a problem hiding this comment.
Wondering why this is needed and the intention of this graylistBackoff?
There was a problem hiding this comment.
Hm. Looking at the existing code in status-go, i believe it is so we dont connect again to this storenode for 3 minutes.
waku/v2/api/history/cycle.go
Outdated
| } | ||
|
|
||
| func (m *StorenodeCycle) verifyStorenodeStatus(ctx context.Context) { | ||
| ticker := time.NewTicker(1 * time.Second) |
There was a problem hiding this comment.
This can be a constant.
richard-ramos
force-pushed
the
storenode-cycle
branch
from
b2d0226
to
b852a92
Compare
richard-ramos
force-pushed
the
storenode-cycle
branch
from
b852a92
to
f29ce5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the storenode cycle code from status-go.
I tried to simplify it a bit but most of the heavy refactoring should be done on a separate PR since this one is already complex enough.
@plopezlpz, @kaichaosun @igor-sirotin @chaitanyaprem:
I'm still working on the unit tests, but so far, while testing status-im/status-go#5857 with Desktop, it looks promising. Reviews are appreciated!