Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiki reorg: Remove conditional rendering BUILD section #6235

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Wiki reorg: Remove conditional rendering BUILD section #6235

merged 1 commit into from
Sep 19, 2024

Conversation

filippoweb3
Copy link
Contributor

@filippoweb3 filippoweb3 commented Sep 17, 2024 •
edited
Loading

Used "Relay Chain" mostly and "Polkadot" where needed.

@filippoweb3 filippoweb3 added the A2 - Please Review Pull request is ready for review. label Sep 17, 2024
@filippoweb3 filippoweb3 self-assigned this Sep 17, 2024
CrackTheCode016
CrackTheCode016 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except capitalization of "Relay Chain", which I am not sure if we are doing in the Wiki

@filippoweb3 filippoweb3 merged commit 5ccf42d into master Sep 19, 2024
3 checks passed
@filippoweb3 filippoweb3 deleted the rm-conditional-rendering branch September 19, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

Assignees

@filippoweb3 filippoweb3

Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filippoweb3 @CrackTheCode016