Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer composition #504

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Prefer composition #504

wants to merge 3 commits into from

Conversation

martinthomson
Copy link
Contributor

@martinthomson martinthomson commented Jul 15, 2024 •
edited by pr-preview bot
Loading

WIP

Closes #298.

Preview | Diff

hober
hober approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, modulo the one obvious typo.

index.bs Outdated Show resolved Hide resolved
@martinthomson martinthomson marked this pull request as ready for review July 22, 2024 20:59
annevk
annevk reviewed Aug 21, 2024
View reviewed changes
index.bs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@hober hober hober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guidance for when to use inheritance vs composition
3 participants
@martinthomson @hober @annevk