Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Take 2] Remove YAML; add disclosures to SD-JWT examples; add protected headers #273

Merged
merged 13 commits into from
May 21, 2024

Conversation

decentralgabe
Copy link
Collaborator

@decentralgabe decentralgabe commented May 16, 2024

Fix #269 and replaces #270
Fix #271
Fix #264


Preview | Diff

@decentralgabe
Copy link
Collaborator Author

have fixed rendering and believe it to be correct. please review cc: @bc-pi @selfissued

@bc-pi
Copy link

bc-pi commented May 20, 2024

one thing that seems like it cannot be correct or intended:
Screenshot 2024-05-20 at 2 28 49 PM

@decentralgabe decentralgabe linked an issue May 20, 2024 that may be closed by this pull request
@decentralgabe
Copy link
Collaborator Author

updated to add tabs for readability
Screenshot 2024-05-20 at 2 22 01 PM

@decentralgabe
Copy link
Collaborator Author

@bc-pi unfortunately...that is correct given the usage of the Enveloped type

this was a ... compromise to include vc-jose-cose secured credentials in presentations. see relevant discussion:

I agree it's ugly. I'd like to see us continue to discuss improving the envelope types in a follow-up issue. I hope this PR at least makes the examples clearer.

@decentralgabe
Copy link
Collaborator Author

merging as this just fixes examples and is purely editorial
open to continuing discussion on how we could improve VPs

@decentralgabe decentralgabe merged commit a169ee8 into main May 21, 2024
2 checks passed
@decentralgabe decentralgabe deleted the sd-jwt-disclosures-no-yaml branch May 21, 2024 01:24
@bc-pi
Copy link

bc-pi commented May 21, 2024

The tabs do help, thanks.

However, (and limiting the commentary to just the scope of this now merged PR) the listing of the value of the claim after "Claim:" under the "Issuer Disclosures" tab rather than the claim name seems incorrect and unhelpful. And makes the aforementioned ugliness more prominent than need be.

@decentralgabe
Copy link
Collaborator Author

thank you @bc-pi I agree that it's confusing. I fixed this in #274 - which you should now see reflected here https://w3c.github.io/vc-jose-cose/#securing-json-ld-verifiable-credentials-with-sd-jwt

@bc-pi
Copy link

bc-pi commented May 21, 2024

Thanks @decentralgabe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show headers in examples Intellectual Property concern wrt. SD-JWT examples Improving the SD-JWT examples
4 participants