Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to normative statements #143

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Changes to normative statements #143

merged 6 commits into from
Sep 8, 2023

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Aug 24, 2023

Aligns with #141

This PR, changes MUST to SHOULD to allow for more specific typing via media types.

This PR also recommends securing with JOSE be done with sd-jwt


Preview | Diff

Copy link
Contributor

@andresuribe87 andresuribe87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions reinforcing the definition of what an SD-JWT is.

Selectively Disclosable JWT (SD-JWT):
A composite structure, consisting of an Issuer-signed JWT (JWS, [RFC7515]), Disclosures, and optionally a Key Binding JWT that supports selective disclosure as defined in this document. It can contain both regular claims and digests of selectively-disclosable claims.

Importantly, an SD-JWT is NOT a JWT.

index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
@Sakurann
Copy link
Contributor

why changing MUST to SHOULD allows more explicit typing..? if there is one media type that is to be used, why not mandate it..? what am I missing

@OR13
Copy link
Contributor Author

OR13 commented Aug 31, 2023

@Sakurann at the last IETF, I asked a lot of people about this... There was some concern over not allowing specific VCs to use the more specific typing, similar to sec+jwt using it... This allows for that to happen with W3C VCs, so perhaps some token processors might do foo+sd-jwt instead of vc+ld+json+sd-jwt... It also reduces the risk of further issues with multiple suffixes in case there are issues that arise with it in the future.

@iherman
Copy link
Member

iherman commented Sep 3, 2023

The issue was discussed in a meeting on 2023-08-30

  • no resolutions were taken
View the transcript

1.1. Changes to normative statements (pr vc-jose-cose#143)

See github pull request vc-jose-cose#143.

Brent Zundel: looking to transition to CR no later than end of September.

Michael Prorock: one PR ready to merge (vc-jose-cose).
… clean things up. better to test.
… should help with test suites.

Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add rationale. Say that it's a SHOULD so that more specific media types can be used.

@TallTed
Copy link
Member

TallTed commented Sep 5, 2023

Including the reason for the SHOULD would be helpful. Might also consider "application/jwt or subtype thereof (e.g., application/sec+jwt)"

@iherman
Copy link
Member

iherman commented Sep 5, 2023

The issue was discussed in a meeting on 2023-09-05

  • no resolutions were taken
View the transcript

4.1. Changes to normative statements (pr vc-jose-cose#143)

See github pull request vc-jose-cose#143.

Orie Steele: lot of discussions about media types at last IETF.
… possibly not a great idea to have very specific key types.
… e.g. all VCs had to have the type of jwt, but you could not know anything about what was in the jwt.
… by using jwt we could not make it any more specific.
… this PR does not preclude using more specific values in future.
… this PR alters the amount of work needed to perform the tests for getting to a standard.
… ie. it reduces the amount of work needed.

Kristina Yasuda: +1 selfissued.

Orie Steele: I agree, but prefer to address that in a separate PR.

Orie Steele: Feel free to file an issue to track the suggested language.

Michael Jones: rationale should be included to say this media type should be used unless a profile specifies a more specific media type.

@OR13
Copy link
Contributor Author

OR13 commented Sep 5, 2023

@selfissued @TallTed added guidance based on your review in : 6a821e1

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language tweaks, to hopefully clarify somewhat...

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
OR13 and others added 2 commits September 6, 2023 13:07
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@OR13
Copy link
Contributor Author

OR13 commented Sep 6, 2023

@TallTed thanks for your suggestions, both are applied. @selfissued can you please re-review.

The most specific media type (or subtype) available SHOULD be used, instead of
more generic media types (or supertypes). For example, rather than the general
<code>application/sd-jwt</code>, <code>application/vc+ld+json+sd-jwt</code>
ought to be used, unless there is a more specific media type that would even
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ought to be used, unless there is a more specific media type that would even
should to be used, unless there is a more specific media type that would even

Copy link
Member

@TallTed TallTed Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ought to was meant to avoid potential confusion of should with SHOULD.

If should is now to be kept, should to be should be changed to should be or perhaps SHOULD be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to avoid the normative language

index.html Show resolved Hide resolved
Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the rationale.

Co-authored-by: Kristina <[email protected]>
@OR13 OR13 merged commit 9e717da into main Sep 8, 2023
2 checks passed
@decentralgabe decentralgabe deleted the adjust/normative-headers branch February 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants