-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/editorial intro and format #112
Conversation
|
||
COSE supports two main operations: signing and encryption. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, maybe a second p tag.
using either JOSE or COSE. | ||
</p> | ||
<p> | ||
A benefit to this approach is that payloads can be made to conform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same issue with payload vs claimset... I don't think it makes sense to call a COSE Sign1 "payload" a "claimset"... I think we will need to do a lot of cleanup if we remove the "native JWT encoding from the spec, basically replacing the word "claimset" with "payload" everywhere, and making it content type explicitly JSON-LD ... and NOT... JSON.
<code>cty</code>. | ||
</p> | ||
<pre class="example vc-jwt" data-vc-kid="#key-0"> | ||
{ "@context": [ "https://www.w3.org/ns/credentials/v2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, on formatting this for spec readability
<p> | ||
See <a data-cite="rfc7515#section-4.1.10">Common JOSE Header | ||
Parameters</a> | ||
for additional details regarding usage of <code>typ</code> and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typ
only works for JSON
payloads... same issue as https://github.com/w3c/vc-jwt/pull/112/files#r1245326420
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - didn't adjust this text, but something we need to address in next pass
|
||
<pre class="example vc-jwt" title="A secured verifiable | ||
presentation with a holder identifier"> | ||
{ "@context": [ "https://www.w3.org/ns/credentials/v2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit on formatting
</p> | ||
<p>[[rfc8152]] MAY be used to secure this media type.</p> | ||
<p>When using this approach, the <code>type (TBD)</code> MUST be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder about this typ
issue... cc @selfissued
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no tag for typ
in COSE Headers, so there is no CWT equivalent of JWT.
Binary Object Representation (CBOR) Tags</a> for additional | ||
details.</p> | ||
</section> | ||
<p class="issue" data-number="67"></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, some text here would help with future editorial cleanup
</section> | ||
|
||
<section> | ||
<h2>Securing JSON</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect we will remove this section, @selfissued remains the only objector to #88
I suggest an editorial issue marker to communicate this better to readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nits, but I don't know if any of them matter.
Please add the issue markers for tag, to assist them in their review
Co-authored-by: Orie Steele <[email protected]>
yeah - the nits are in sections i didn't touch - only non-format changes were in doc title and abstract/intro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with new short name "vc-jose-cose"
Curious how this will be performed? Will this repository be renamed?
Will leave that to the chairs, but is suspect that will be the case |
@selfissued need to get this one merged so that we are building on consistent formatting - blocking addressing of additional PRs to address notes from @OR13 above |
since this is hard to read due to reformatting, the actual changes are here (everything else untouched): changes:
added/adjusted:
added:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with two comments to address before merging.
Editorial, merging |
mechanism for digitally signing JSON data. It provides a means | ||
to ensure the integrity, authenticity, and non-repudiation of | ||
the information contained in a JSON object. JWS enables secure | ||
communication and trust between parties by adding a | ||
cryptographic signature to a payload. This signature is | ||
generated using a private key and can be verified using the | ||
corresponding public key. JWS enables content integrity, authentication and non repudiation, | ||
protecting data from unauthorized modifications. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs re-reading...
It provides a means
to ensure the integrity, authenticity, and non-repudiation of
the information contained in a JSON object.
is redundant with
JWS enables content integrity, authentication and non repudiation,
protecting data from unauthorized modifications.
Many line number changes here. Actual changes in this:
Preview | Diff