-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on JSON Processing. #1202
Conversation
Isn't this more of just a JSON-LD issue than a VC issue? I am not sure I see the value of this PR as it is just saying that JSON-LD is JSON |
Thank you @msporny for the clarification PR, I'm in favour of including this PR as is. @mprorock wrote:
I would say that it is beneficial for the community that is less technical than average contributor. The clarification is very clearly specifying the duality and the differences of json-ld/json in context of VC/VP, while promoting the use of @context. This "promoted" use of the mandatory @context is against pure json mindset, thus this added section is beneficial for the community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preemptively approving given a small number of tweaks. great addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR creates more confusion than clarification. One is confusion between payload and securing mechanism processing. Even for the the payload processing, since the base data model is +ld+json, JSON-LD is needed and for example it's misleading to talk about only +json.
index.html
Outdated
<li> | ||
When using the JOSE or COSE specifications to secure a | ||
<a>verifiable credential</a> or <a>verifiable presentation</a>. | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li> | |
When using the JOSE or COSE specifications to secure a | |
<a>verifiable credential</a> or <a>verifiable presentation</a>. | |
</li> |
This is a confusion between payload and securing mechanism processing. this should talk only about the payload which is JSON-LD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b136572
to
91cb4e6
Compare
I will no longer block this PR if this is well documented in #1227. If we don't do that, the JSON section just leads to developer confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still doubt the usefulness of this section but I'm not blocking it either.
Noting conflicts exist, there are new change suggestions, and despite @awoie 's comment here: #1202 (comment) He is still marked as blocking the PR... as is @Sakurann . |
He has indicated that he no longer wishes to block this PR #1202 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with others that this information will be much better once accompanied by the changes discussed in issue #1227
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the work that has gone into this PR. Not blocking. Looking forward to a similar section on JSON-LD processing.
The issue was discussed in a meeting on 2023-08-09
View the transcript2.3. Add section on JSON Processing. (pr vc-data-model#1202)See github pull request vc-data-model#1202. Manu Sporny: PR 1202, everyone who needs to reviewed has reviewed, need JSON/JSON-LD processing section, conflicts needs to be resolved, plan to merge tomorrow. |
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Mike Prorock <[email protected]> Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Mike Prorock <[email protected]>
Co-authored-by: Orie Steele <[email protected]>
Co-authored-by: Orie Steele <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
…ing. Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
e0b7b84
to
f007a19
Compare
Editorial, substantive, multiple reviews, changes requested and made, no remaining objections, merging. |
This PR attempts to address issue #1201 by documenting how systems process the VCDM using pure JSON processing today.
Preview | Diff