Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvelopedVerifiablePresentation missing in data model #1431

Closed
OR13 opened this issue Feb 3, 2024 · 5 comments
Closed

EnvelopedVerifiablePresentation missing in data model #1431

OR13 opened this issue Feb 3, 2024 · 5 comments
Assignees
Labels
CR1 This item was processed during CR1 normative The PR is a normative change to the CR specification pr exists

Comments

@OR13
Copy link
Contributor

OR13 commented Feb 3, 2024

prevents consistent RDF interpretation of presentations secured without data integrity proofs.

{
   "@context": "https://www.w3.org/ns/credentials/v2",
    "id": "data:application/vp+ld+json+sd-jwt;QzVjV...RMjU",
    "type": "EnvelopedVerifiablePresentation"
}
@iherman
Copy link
Member

iherman commented Feb 14, 2024

The issue was discussed in a meeting on 2024-02-14

  • no resolutions were taken
View the transcript

2.5. EnvelopedVerifiablePresentation missing in data model (issue vc-data-model#1431)

See github issue vc-data-model#1431.

Brent Zundel: next is #1431 EnvelopedVerifiablePresentation missing in data model.

Gabe Cohen: prevents consistent RDF interpretation of presentations secured without data integrity proofs.

Manu Sporny: today we have this concept of an enveloped verifiable credential, with a presentation inside of it. this would add a presentation. should be fine to do this. it is something that is missing. it is a normative change. saying "if you want to, you can wrap it in multiple b64 payloads" to get a blob that secures the entire data model using any media type.

Brent Zundel: clarifying...the enveloped cred was 'I want to use vc-jose-cose to sign a credential' this is 'I want to use vc-jose-cose to sign a presentation'.

Manu Sporny: yes correct and I can take it.

Ivan Herman: I will take the vocab part.

Brent Zundel: thanks to both. time for at least one more...#1408.

@iherman
Copy link
Member

iherman commented Feb 15, 2024

@msporny we should not do the relevant PR (at least on the vocabulary) before closing #1436...

@msporny msporny added CR1 This item was processed during CR1 and removed CR2 labels Mar 3, 2024
@msporny
Copy link
Member

msporny commented Mar 3, 2024

PR #1453 has been raised to address this issue. This issue will be closed once PR #1453 has been merged.

@iherman
Copy link
Member

iherman commented Mar 6, 2024

The issue was discussed in a meeting on 2024-03-06

  • no resolutions were taken
View the transcript

2.14. EnvelopedVerifiablePresentation missing in data model (issue vc-data-model#1431)

See github issue vc-data-model#1431.

See github pull request vc-data-model#1453.

Brent Zundel: 1431, PR1453 which has approvals and on track to be merged.
… we're headed toward wrapping this up.
… so expect to be bothered by us to get the work done...probably weekly.

@msporny
Copy link
Member

msporny commented Mar 9, 2024

PR #1453 has been merged, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during CR1 normative The PR is a normative change to the CR specification pr exists
Projects
None yet
Development

No branches or pull requests

3 participants