Add expires example to proof. #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
davidlehn,
dlongley,
jandrieu,
iherman,
dmitrizagidulin,
TallTed,
decentralgabe and
brentzundel
TallTed
suggested changes
Oct 2, 2024
| @@ -926,6 +926,27 @@ <h3>Proofs</h3> | |||
| representing time values to individuals. | |||
| </p> | |||
|
|
|||
| <pre class="example nohighlight" | |||
| title="A proof attached to a data document that uses the 'expires' property"> | |||
There was a problem hiding this comment.
Suggested change
| title="A proof attached to a data document that uses the 'expires' property"> | |
| title="A proof that uses the 'expires' property, attached to a data document"> |
There was a problem hiding this comment.
or
Suggested change
| title="A proof attached to a data document that uses the 'expires' property"> | |
| title="A data document with an attached proof that uses the 'expires' property"> |
dlongley
approved these changes
Oct 3, 2024
| "type": "DataIntegrityProof", | ||
| "cryptosuite": "ecdsa-rdfc-2019", | ||
| "created": "2020-06-11T19:14:04Z", | ||
| <span class="comment">// the proof expires a month after it was issued</span> |
There was a problem hiding this comment.
Suggested change
| <span class="comment">// the proof expires a month after it was issued</span> | |
| <span class="comment">// the proof expires a month after it was created</span> |
| "cryptosuite": "ecdsa-rdfc-2019", | ||
| "created": "2020-06-11T19:14:04Z", | ||
| <span class="comment">// the proof expires a month after it was issued</span> | ||
| <span class="highlight">expires": "2020-07-11T19:14:04Z"</span>, |
There was a problem hiding this comment.
Suggested change
| <span class="highlight">expires": "2020-07-11T19:14:04Z"</span>, | |
| <span class="highlight">"expires": "2020-07-11T19:14:04Z"</span>, |
iherman
approved these changes
Oct 3, 2024
Wind4Greg
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #313 by adding a proof to the specification that uses the
expiresproperty./cc @filip26
Preview | Diff