Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated yml vocabulary file #280

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

iherman
Copy link
Member

@iherman iherman commented Jul 4, 2024

The terms defined now in the controller document refer, for their formal definition, to that one (instead of the DI spec).

Some minor errors also handled.

As usual, the preview feature does not show the vocabulary file; to look at the HTML file, see the HTML Preview

@iherman iherman added CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. labels Jul 4, 2024
Copy link
Collaborator

@Wind4Greg Wind4Greg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR include the error code updates or a separate PR?

@iherman
Copy link
Member Author

iherman commented Jul 5, 2024

Should this PR include the error code updates or a separate PR?

I am not sure where we are with that update on your side. The current version is in sync (I hope) with the official version of the DI spec and does not refer to any other error code. Is that still subject to change?

If yes, I would prefer to update this file when all other relevant specs are at an equilibrium.

@msporny msporny force-pushed the vocabulary-with-credential-document branch from 016aa0b to 6b2c337 Compare July 7, 2024 16:05
@msporny
Copy link
Member

msporny commented Jul 7, 2024

Purely editorial (updates links), merging.

@msporny msporny merged commit 35703f7 into main Jul 7, 2024
2 checks passed
@msporny msporny deleted the vocabulary-with-credential-document branch July 7, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants