Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File report on Missing tasks in parallel steps in Payment Request API #779

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

dontcallmedom-bot
Copy link
Contributor

This pull request was automatically created by Strudy upon detecting errors in Missing tasks in parallel steps in Payment Request API.

Please check that these errors were correctly detected, and that they have not already been reported in https://github.com/w3c/payment-request.

If everything is OK, you can merge this pull request which will report the issue below to the repo, and update the underlying report file with a link to the said issue.


Title: Missing tasks in parallel steps in Payment Request API
Tracked: N/A
Repo: 'https://github.com/w3c/payment-request'

While crawling Payment Request API, the following algorithms fire an event, or resolve or reject a Promise, within a step that runs in parallel without first queuing a task:

  • The algorithm that starts with "The show(optional detailsPromise) method MUST act as follows:" resolves/rejects a promise directly in a step that runs in parallel
  • The algorithm that starts with "The complete() method MUST act as follows:" resolves/rejects a promise directly in a step that runs in parallel
  • The can make payment algorithm algorithm resolves/rejects a promise directly in a step that runs in parallel

See Dealing with the event loop in the HTML specification for guidance on how to deal with algorithm sections that run in parallel.

Cc @dontcallmedom @tidoust

This issue was detected and reported semi-automatically by Strudy based on data collected in webref.

@dontcallmedom dontcallmedom merged commit 6dbe1b3 into main Sep 10, 2024
1 check passed
@dontcallmedom dontcallmedom deleted the payment-request-missingtask branch September 10, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants