Enhance with semantic HTML5 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a little `time` here and there. - Add `kbd` elements to the explanation of access keys. - Some uses of the `kbd` element were used for commands, but these commands are themselves `code`. - Changed `<blockquote><pre>` to `<code><pre>`. - Update CSS.
**NOTE: Untested!** I don’t know how to set up a server to test these changes. I tried my best to be careful with the changes. ---- - Use `sections` to group each checked URL - Use a `data-url-checked` attribute on the `section` (to make scraping or client-side DOM manipulation easier) - Updated to use HTML5 `progress` element
|
@dontcallmedom Open to review this one? |
|
I write Perl every day - do you want me to check it? |
|
@halindrome Absolutely! Have it it :) 👍 |
|
@halindrome Is it working okay? |
@halindrome I take it work has got in the way? No worries. If you change your mind, it's probably a very simple review for someone who knows Perl. If not: Anyone else who knows #perl willing to review this PR? |
|
@Zearin you marked this PR as draft - is it now ready to be merged from your perspective? |
|
@dontcallmedom If it works as intended, go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be properly tested!
I have barely used Perl, and even then…
That said, I tried to be careful with these changes, and I’m pretty sure everything should work out fine.
If it works, this will sprinkle a dash of modern markup into things. As a nice side effect, grouping each checked URL in its own
sectionwill make scraping or DOM-manipulating a long results list (an inevitability with recursive link checking) a little bit easier.