Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Level of Assurance (LoA) section; fixes #151; fixes #391 #568

Merged
merged 16 commits into from
Jan 28, 2021

Conversation

awoie
Copy link
Contributor

@awoie awoie commented Jan 21, 2021

As per @peacekeeper request, I tried to come up with a PR that covers LoAs; fixes #151


Preview | Diff

@peacekeeper
Copy link
Contributor

peacekeeper commented Jan 21, 2021

This also addresses #391

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is a useful addition to the Security Considerations section that addresses #151 and #391 and will be relevant to some of the use cases. Maybe it would also be worth mentioning FIDO attestations? In any case, I'm fine with merging this (after applying @TallTed 's fixes).

awoie and others added 5 commits January 22, 2021 12:56
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@awoie
Copy link
Contributor Author

awoie commented Jan 22, 2021

Thanks, I think this is a useful addition to the Security Considerations section that addresses #151 and #391 and will be relevant to some of the use cases. Maybe it would also be worth mentioning FIDO attestations? In any case, I'm fine with merging this (after applying @TallTed 's fixes).

@peacekeeper I will add FIDO, FIDO 2 / WebAuthn etc. as examples for SCA. I could also add examples for NIST, ISO, eIDAS LoA frameworks if useful.

@TallTed
Copy link
Member

TallTed commented Jan 22, 2021

(probably worth also adjusting title of this PR, espexcially typo assrance -> assurance,
but also level of assurance -> "Level of Assurance (LoA)")

@awoie awoie changed the title added level of assrance section; fixes #151 added level of assurance section; fixes #151; fixes #391 Jan 22, 2021
@awoie awoie changed the title added level of assurance section; fixes #151; fixes #391 Added Level of Assurance (LoA) section; fixes #151; fixes #391 Jan 22, 2021
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM, thanks @awoie! :)

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@awoie
Copy link
Contributor Author

awoie commented Jan 25, 2021

I added some references to NIST, ISO, FIDO/Webauthn.

@peacekeeper
Copy link
Contributor

Maybe @Oskar-van-Deventer also wants to review this, since his issue #151 was the original inspiration for addressing this topic in the spec.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
awoie and others added 2 commits January 26, 2021 11:56
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should also say that Verifiable Credentials are an appropriate way to convey this information as well. We can do this editorially or in a future PR.

@msporny
Copy link
Member

msporny commented Jan 28, 2021

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 64397a7 into w3c:main Jan 28, 2021
Copy link
Contributor

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include discussion of eIDAS levels-of-assurance
5 participants