-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-flexbox-1] To transferred min/max constraints get applied to the min/max main sizes? #10997
Labels
css-flexbox-1
Current Work
Comments
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Oct 3, 2024
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390 ... introduced a change where we applied the transferred min/max sizes to the inline min/max sizes. This was unintentional. The spec is unclear on this situation (after checking with the spec author), so filed an issue here: w3c/csswg-drafts#10997 We may change back again, but at least this brings us in-line with other browsers for the moment. Fixed: 368562235 Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Oct 3, 2024
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390 ... introduced a change where we applied the transferred min/max sizes to the inline min/max sizes. This was unintentional. The spec is unclear on this situation (after checking with the spec author), so filed an issue here: w3c/csswg-drafts#10997 We may change back again, but at least this brings us in-line with other browsers for the moment. Fixed: 368562235 Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907910 Reviewed-by: David Grogan <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363796}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Oct 3, 2024
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390 ... introduced a change where we applied the transferred min/max sizes to the inline min/max sizes. This was unintentional. The spec is unclear on this situation (after checking with the spec author), so filed an issue here: w3c/csswg-drafts#10997 We may change back again, but at least this brings us in-line with other browsers for the moment. Fixed: 368562235 Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907910 Reviewed-by: David Grogan <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363796}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Oct 3, 2024
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390 ... introduced a change where we applied the transferred min/max sizes to the inline min/max sizes. This was unintentional. The spec is unclear on this situation (after checking with the spec author), so filed an issue here: w3c/csswg-drafts#10997 We may change back again, but at least this brings us in-line with other browsers for the moment. Fixed: 368562235 Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907910 Reviewed-by: David Grogan <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363796}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR this testcase:
Should the rect be 100x50 (Firefox/WebKit) or 50x50 (Blink temporarily).
Basically all browsers were previously ignoring the transferred max constraint in this case. Blink shipped an (unintentional) behaviour change and received a bug report about it.
I'm going to change Blink back for the moment, but this case seems un-addressed in the spec currently.
@tabatkins @fantasai
The text was updated successfully, but these errors were encountered: