Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax aria-valuenow requirement on slider role #2290

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

adampage
Copy link
Member

@adampage adampage commented Jul 20, 2024

Closes #2260

Relaxes a requirement for the slider role by permitting authors to omit aria-valuenow in favor of aria-valuetext alone.

I purposefully left the adjacent “browsers MAY implement the repair techniques...” statement unchanged, as well as the slider-specific repair technique that it cross-references. Both still seemed compatible with this change.

My introduction of “or” in the slider’s Required States and Properties cell on line 7738 looks unprecedented in the spec in terms of its format. I’d be grateful for the editors to weigh in on that?

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

  • "author MUST" tests:
  • "user agent MUST" tests:
  • Browser implementations (link to issue or commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations?
  • Related APG Issue/PR:
  • MDN Issue/PR:

Preview | Diff

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 6475927
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66aae5d62ba13900080b84d7
😎 Deploy Preview https://deploy-preview-2290--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adampage
Copy link
Member Author

Hi @daniel-montalvo, could you advise me on this prettier error?

@adampage adampage self-assigned this Jul 20, 2024
@daniel-montalvo
Copy link
Contributor

Thanks @adampage I approve this since it is coming from a fork.

@pkra This is complaining because it can't find the branch relax-aria-valuenow, which I guess makes sense because this is coming from a fork. Is this expected behavior?

In any case, weren't we supposed to disable prettier for ARIA for now?

index.html Outdated Show resolved Hide resolved
@spectranaut
Copy link
Contributor

Thanks @adampage I approve this since it is coming from a fork.

@pkra This is complaining because it can't find the branch relax-aria-valuenow, which I guess makes sense because this is coming from a fork. Is this expected behavior?

In any case, weren't we supposed to disable prettier for ARIA for now?

I opened an issue for the prettier issue: #2294

@jnurthen jnurthen self-requested a review July 25, 2024 17:23
index.html Outdated Show resolved Hide resolved
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some suggested text to clarify the aria-valuenow repair should only occur if both aria-valuetext and aria-valuenow are missing.

I'd also like to see user agent or AT SHOULD NOT expose an aria-valuenow fallback value if the aria-valuetext is specified but aria-valuenow is not. For instance, in my recent testing i recall screen readers (though don't remember exactly which ones) would expose a fallback value when aria-valuenow wasn't specified (usually a 50%)

@adampage
Copy link
Member Author

I'd also like to see user agent or AT SHOULD NOT expose an aria-valuenow fallback value if the aria-valuetext is specified but aria-valuenow is not.

Here’s a stab at that, @scottaohara.

@adampage
Copy link
Member Author

Heya @jnurthen, quick editors question: I just noticed that the spec seems to prefer “user agents” over “browsers” for normative statements? I found only 2 matches for \bBrowser(s)?\s+(MAY|SHOULD|MUST)\b versus 77 for user agent(s).

One of those 2 “browser” matches was in this PR’s slider section, so I swapped it out in this latest commit. Would it be scope creep for me to just take care of the last remaining one (in the scrollbar section).

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@adampage adampage requested a review from smhigley August 1, 2024 00:52
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that additional change/comment, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should aria-valuenow be required if aria-valuetext is used?
5 participants