-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax aria-valuenow
requirement on slider
role
#2290
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @daniel-montalvo, could you advise me on this prettier error? |
Thanks @adampage I approve this since it is coming from a fork. @pkra This is complaining because it can't find the branch relax-aria-valuenow, which I guess makes sense because this is coming from a fork. Is this expected behavior? In any case, weren't we supposed to disable prettier for ARIA for now? |
I opened an issue for the prettier issue: #2294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some suggested text to clarify the aria-valuenow repair should only occur if both aria-valuetext and aria-valuenow are missing.
I'd also like to see user agent or AT SHOULD NOT expose an aria-valuenow fallback value if the aria-valuetext is specified but aria-valuenow is not. For instance, in my recent testing i recall screen readers (though don't remember exactly which ones) would expose a fallback value when aria-valuenow wasn't specified (usually a 50%)
Co-authored-by: Scott O'Hara <[email protected]>
Here’s a stab at that, @scottaohara. |
Heya @jnurthen, quick editors question: I just noticed that the spec seems to prefer “user agents” over “browsers” for normative statements? I found only 2 matches for One of those 2 “browser” matches was in this PR’s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With that additional change/comment, LGTM!
Closes #2260
Relaxes a requirement for the
slider
role by permitting authors to omitaria-valuenow
in favor ofaria-valuetext
alone.I purposefully left the adjacent “browsers MAY implement the repair techniques...” statement unchanged, as well as the
slider
-specific repair technique that it cross-references. Both still seemed compatible with this change.My introduction of “or” in the
slider
’s Required States and Properties cell on line 7738 looks unprecedented in the spec in terms of its format. I’d be grateful for the editors to weigh in on that?Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff