Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Adds script to get ARIA participants and Respec gh-contributors functionality to the specs that did not have it #2288

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Editorial: Adds script to get ARIA participants and Respec gh-contributors functionality to the specs that did not have it #2288

wants to merge 10 commits into from

Conversation

daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Jul 19, 2024 •
edited by pr-preview bot
Loading

@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 83e555d
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66c5d49979e924000869d85a
😎 Deploy Preview https://deploy-preview-2288--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-montalvo daniel-montalvo added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo Agenda-Editors labels Jul 19, 2024
@daniel-montalvo daniel-montalvo self-assigned this Jul 19, 2024
@daniel-montalvo daniel-montalvo changed the title Adds script to get ARIA participants and Respec gh-contributors functionality to the spec that did not have it Adds script to get ARIA participants and Respec gh-contributors functionality to the specs that did not have it Jul 19, 2024
spectranaut
spectranaut approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!!

@spectranaut spectranaut changed the title Adds script to get ARIA participants and Respec gh-contributors functionality to the specs that did not have it Editorial: Adds script to get ARIA participants and Respec gh-contributors functionality to the specs that did not have it Aug 13, 2024
@spectranaut spectranaut mentioned this pull request Aug 13, 2024
Open
spectranaut
spectranaut previously requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in the editors meeting and we noticed some things.

Actually, "B.1 ARIA WG participants at the time of publication" is empty in all the specs!

And, we need to better understand the list of gh contributors, we probably need to move that to all the contributors to this repo. We expect it to be the same list for all specs.

@daniel-montalvo
Copy link
Contributor Author

@spectranaut It seems it works in the browser but not when taking a static snapshot. I'll have to figure out why.

@daniel-montalvo daniel-montalvo dismissed spectranaut’s stale review August 21, 2024 12:07

Script is updated and works for most of the specs now

@daniel-montalvo
Copy link
Contributor Author

daniel-montalvo commented Aug 21, 2024 •
edited
Loading

@spectranaut @pkra

The script should now be functional for the following specs when generating a static snapshot with Respec:

It still does not work for SVG-AAM, as they are using an old respec profile that we should probably move away from at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkra pkra Awaiting requested review from pkra

@jnurthen jnurthen Awaiting requested review from jnurthen

@spectranaut spectranaut Awaiting requested review from spectranaut

At least 1 approving review is required to merge this pull request.

Assignees

@daniel-montalvo daniel-montalvo

Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove aria-wg-active.md and aria-wg-participants.md ?
2 participants
@daniel-montalvo @spectranaut