Pass command line arguments to downloaded installer

[zsszatmari]

With this patch you can specify a sparkle:arguments tag in the appcast xml, and that will be passed to the downloaded executable. Intended typical use case is something like "/SILENT", see #21
Thank You for pulling!

[GitCop]

Thanks for contributing! Unfortunately there were the following style issues with your Pull Request:

• Commit: f9c2244
  • Your subject line is longer than 50 characters

Please see https://github.com/agis-/git-style-guide (you can use git push -f to update this PR)

---

This message was auto-generated by https://gitcop.com

[GitCop]

Thanks for contributing! Unfortunately there were the following style issues with your Pull Request:

• Commit: 7e074ce
  • Your subject line is longer than 50 characters

Please see https://github.com/agis-/git-style-guide (you can use git push -f to update this PR)

---

This message was auto-generated by https://gitcop.com

[vslavik]

In addition to GitCop’s stylistic comments (can you please fix the issues; see the style guide?), can you please also organize the commits a bit more logically (“make it part of sparkle namespace” is neither a self-contained commit nor explanatory message and shouldn’t be a separate commit in the first place)?

I also have some additional comments:

• It’s not clear to me what does the "passing arguments to installer works” commit do, neither from its (virtually non-existent) description nor the code. It seems the previous commit was completely broken, right? If so, make it one, self-contained and working commit, to preserve at least some minimal git hygiene (again, please see the guide).
• Please be respectful to the original code’s formatting. If it doesn’t use tabs, don’t add them all over the place, as you did here. It only distracts from the real changes in the code and makes reading and maintaining the code harder.
• Please fix the wxExecute use as discussed above in per-file comments.

Don’t take me wrong: I would LOVE to merge this in once the issues are fixed. But I can’t merge it as-is.

[zsszatmari]

Fixed issues, pushed!

[zsszatmari]

Hi!

Let me know if you decided on sparkle:installerArguments tag, or if you have any other suggestions which are needed for merging.
Have a nice day!

[vslavik]

Let me know if you decided on sparkle:installerArguments tag

Apparently, nobody else gives a damn, so let’s use sparkle:installerArguments as you did for simplicity. Re wxLaunchDefaultApplication, I think it shouldn’t be necessary (even files like MSIs are directly executable on modern (i.e. XP+) Windows). But I think you convinced me to play it safe.

In short, technically speaking, the above is just about perfect — thanks a lot!

Could you please respect the file’s formatting, though? I think you’re not seeing it locally due to your editor settings, but look at the d833742 diff at GitHub: it’s full of whitespace changes all over the place and other strange formatting inconsistent with not only the rest of the code but even itself (space after ( but not before ), { at the end and not separate line, } else {) and tabs, tabs everywhere. If you could fix this, I would appreciate it; if not, I’ll --amend it myself in the next few days before pushing.

[zsszatmari]

File formatting <= Sure, I will clean up tomorrow or the day after.

[zsszatmari]

Got a little time so I corrected the style issues, and also made variable names more consistent (no more 'updateArguments').

[vslavik]

Merged, thanks!

I also added documentation to https://github.com/vslavik/winsparkle/wiki/Appcast-Feeds#installer-arguments, feel free to update it as needed if I got anything wrong.

[zsszatmari]

You're welcome, thanks for merging!