Add logic to detect ARM updates from the appcast file. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I'd call it a follow-up to #50 instead (noting to get cross-referenced from there). Will also need to update https://github.com/vslavik/winsparkle/wiki/Appcast-Feeds accordingly after merging... |
vslavik
reviewed
Dec 28, 2023
src/appcast.cpp
Outdated
| @@ -212,10 +213,14 @@ bool is_suitable_windows_item(const Appcast &item) | |||
|
|
|||
| // Check suffix for matching bitness | |||
| #ifdef _WIN64 | |||
| #ifdef __AARCH64EL__ || _M_ARM64 | |||
There was a problem hiding this comment.
This is incorrect, it needs to be #if defined(__AARCH64EL__) || defined(_M_ARM64).
Also, where does __AARCH64EL__ come from? Can't find any reference to in relation to Windows...
There was a problem hiding this comment.
__AARCH64EL__ is defined by LLVM MinGW:
parallels@ubuntu-linux-22-04-desktop:~/winsparkle/build$ aarch64-w64-mingw32-clang -E -dM - </dev/null | grep AARCH64
#define __AARCH64EL__ 1
#define __AARCH64_CMODEL_SMALL__ 1
parallels@ubuntu-linux-22-04-desktop:~/winsparkle/build$
Unfortunately it doesn't look like that version of MinGW defines _M_ARM64, so we can't simply check for that.
There was a problem hiding this comment.
Also, ifdef has been changed to if defined() per your above comment.
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #265 to enable WinSparkle to allow users to specifically provide ARM64 releases in the appcast file.