Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Hiera compatibility #905

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Better Hiera compatibility #905

merged 4 commits into from
Nov 7, 2023

Commits on Nov 6, 2023

  1. Use include postgresql::server in zabbix::database 

    This is safe to do because it can be called even after an explicit class
statement. The following code is legal.

    class { 'postgresql::server':
    }
    include postgresql::server

It could make a difference for a remote database, but due to the usage
of postgresql::server::pg_hba_rule that was already invalid.

The explicit require is also not needed, since postgresql::server::db
already does this where needed.

The end result is that the module is easier to use.
    @ekohl
    ekohl committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    21a1a35 View commit details
    Browse the repository at this point in the history

  2. include mysql::server if needed 

    This is similar to the inclusion of postgresql::server if needed.
    @ekohl
    ekohl committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7f9ba73 View commit details
    Browse the repository at this point in the history

  3. Include apache::mod::php if needed

    @ekohl
    ekohl committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    215c5b7 View commit details
    Browse the repository at this point in the history

  4. Provide Apache & PostgreSQL params via Hiera 

    By using beaker-hiera there is no need to provide it in every acceptance
test.
    @ekohl
    ekohl committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    56e30df View commit details
    Browse the repository at this point in the history