Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap agent2 support (continued) - Waiting for postgresql fix #868

Closed
wants to merge 2 commits into from
Closed

Bootstrap agent2 support (continued) - Waiting for postgresql fix #868

wants to merge 2 commits into from

Conversation

Phil-Friderici
Copy link

In this PR I try to continue the work of fe80 (and others) in PR824.

Pull Request (PR) description

This Pr bootstrap a support for zabbix-agent2

  • Add param binary_location for specify zabbix agent binary (only for systemd)
  • Remove some parameters in zabbix agent configuration if it's zabbix agent2 package
    • LogRemoteCommands
    • StartAgents
    • MaxLinesPerSecond
    • AllowRoot
    • User
    • LoadModulePath

It's possible to use agent2 with this configration:

      'agent_configfile_path' => '/etc/zabbix/zabbix_agent2.conf',
      'include_dir'           => '/etc/zabbix/zabbix_agent2.d',
      'pidfile'               => '/var/run/zabbix/zabbix_agentd2.pid',
      'servicename'           => 'zabbix-agent2',
      'zabbix_package_agent'  => 'zabbix-agent2',
      'binary_location'       => '/usr/sbin/zabbix_agent2',

I actually not test with windows kernel.

This Pull Request (PR) fixes the following issues

Fixes #692

@fe80
Bootstrap agent2 support
b7248fb 
* Add param binary_location for specify zabbix agent binary (only for
  systemd)
* Remove some parameters in zabbix agent configuration if it's zabbix
  agent2 package
    * LogRemoteCommands
    * StartAgents
    * MaxLinesPerSecond
    * AllowRoot
    * User
    * LoadModulePath
* Fix EnableRemoteCommands still use on zabbix agentd > 5 but remove on
  agent2
@Phil-Friderici
Copy link
Author

Rebased against master.

@Phil-Friderici
Copy link
Author

The spec tests all run fine when using puppetlabs/postgresql v7.5.0 instead. The latest version of postgresql introduced a bug that does fail on ArchLinux. I have create the issue#1408 with a description of the problem and @smortex was so kind (merci beaucoup!) to create PR#1410 to get it fixed.

Currently they are working on a fix and I am looking forward for a new fixed release of postgresql that should work well with this code.

Regarding the failing of the acceptance tests, I am not sure what is needed to fix them. Any help would be very appreciated.

@Phil-Friderici Phil-Friderici changed the title Bootstrap agent2 support (continued) - Work in progress Bootstrap agent2 support (continued) - Waiting for postgresql fix Mar 29, 2023
Fix broken dependency to puppetlabs/apache module
b63ad19 
* Copy apache_version from puppetlabs/apache v8.x module.
  Puppetlabs removed apache_version with the v9 release of the apache module.
  apache_version was used to distiguish between the needed settings.
@Phil-Friderici
Copy link
Author

Phil-Friderici commented Nov 13, 2023 •
edited
Loading

Closed in favour of #914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Zabbix Agent 2
2 participants
@Phil-Friderici @fe80