Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timescaledb #827

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Timescaledb #827

wants to merge 7 commits into from

Conversation

bdeferme
Copy link

Pull Request (PR) description

Import the zabbix timescaledb schema with a boolean flag.

This Pull Request (PR) fixes the following issues

n/a

@bdeferme
Copy link
Author

bdeferme commented Sep 5, 2022

Not sure why some of the checks are failing. Any news on reviewing my PR 😃 ?

Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This will need some basic unit tests before it can be merged into the master branch. You can take a look at database_postgresql_spec and add the necessary spec.

manifests/init.pp Show resolved Hide resolved
manifests/server.pp Show resolved Hide resolved
manifests/database/postgresql.pp Outdated Show resolved Hide resolved
@bdeferme
Copy link
Author

Thanks for the PR!

This will need some basic unit tests before it can be merged into the master branch. You can take a look at database_postgresql_spec and add the necessary spec.

I added a basic test


it { is_expected.to compile.with_all_deps }
it { is_expected.to contain_exec('update_pgpass').with_command('echo node01.example.com:6432:zabbix-server:zabbix-server:zabbix-server >> /root/.pgpass') }
it { is_expected.to contain_exec('zabbix_server_create.sql').with_command("cd #{path} && if [ -f #{sql_server}.gz ]; then gunzip -f #{sql_server}.gz ; fi && psql -h 'node01.example.com' -U 'zabbix-server' -p 6432 -d 'zabbix-server' -f #{sql_server} && touch /etc/zabbix/.schema.done") }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Suggested change
it { is_expected.to contain_exec('zabbix_server_create.sql').with_command("cd #{path} && if [ -f #{sql_server}.gz ]; then gunzip -f #{sql_server}.gz ; fi && psql -h 'node01.example.com' -U 'zabbix-server' -p 6432 -d 'zabbix-server' -f #{sql_server} && touch /etc/zabbix/.schema.done") }
it { is_expected.to contain_exec('zabbix_server_create.sql').with_command("cd #{path} && if [ -f #{sql_server}.gz ]; then gunzip -f #{sql_server}.gz ; fi && psql -h 'node01.example.com' -U 'zabbix-server' -p 5432 -d 'zabbix-server' -f #{sql_server} && touch /etc/zabbix/.schema.done") }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bdeferme - just curious if you saw this. Asking because I came here looking for the timescaledb support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants