Disable null values #120
Merged
Disable null values #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An implementation with tests that covers all basic variants of types and java
Now, if the object should be generated, all necessary fields will be set to the default value
AbdullinAM
reviewed
Aug 20, 2024
kex-core/src/main/kotlin/org/vorpal/research/kex/parameters/Parameters.kt
Outdated
Show resolved
Hide resolved
kex-core/src/main/kotlin/org/vorpal/research/kex/parameters/Parameters.kt
Show resolved
Hide resolved
AbdullinAM
reviewed
Aug 20, 2024
| set(name to fieldType, transformExistingDescriptor(desc, fieldType, cm, alreadyCopied)) | ||
| } | ||
| } | ||
| }.also { alreadyCopied[descriptor] = it } |
There was a problem hiding this comment.
You need to add descriptor to alreadyCopied before calling transformExistingDescriptor recursively.
Because currently your implementaion will not protect you from loops inside object, e.g.:
x = foo.Node {
(link, foo.Node) = x
}
Added a cache to comprehend possible cycles in the generation loops as well as instantiated all the array's elements
khbminus
force-pushed
the
khbminus/disable-null-values
branch
from
1467ee7
to
190a8a4
Compare
AbdullinAM
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request added a new flag:
kex.generateNullValueswith the default value of true.If the flag is set to false, it will replace all null values immediately after it's obtained from SMT solver to the default value.
For the classes the method sets all the fields that are defined in their default values as well.