Mocking #108
Merged
Mocking #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix replaceUninstantiableWithMocks
# Conflicts: # core/src/main/kotlin/org/vorpal/research/kex/util/KfgClassLoader.kt # kex-executor/src/main/kotlin/org/vorpal/research/kex/launcher/WorkerLauncher.kt
# Conflicts: # kex-annotation-processor/src/main/resources/SMTConverter.vm
`generateInitialDescriptors` returns `InitialDescriptors`
# Conflicts: # kex-core/src/main/kotlin/org/vorpal/research/kex/util/rt.kt # kex-executor/src/main/kotlin/org/vorpal/research/kex/launcher/WorkerLauncher.kt # kex-runner/src/main/kotlin/org/vorpal/research/kex/compile/CompilerHelper.kt # kex.py
AbdullinAM
requested changes
Apr 10, 2024
| @@ -296,6 +307,11 @@ class ClassInstantiationDetector( | |||
| override fun cleanup() {} | |||
|
|
|||
| override fun visit(klass: Class) { | |||
| if (ignoredInstantiations.any { it.matches(klass) }) { | |||
There was a problem hiding this comment.
Why do we need an ignore option here? What kind of classes do we want to filter out?
kex-core/src/main/kotlin/org/vorpal/research/kex/util/HackedClassLoader.kt
Outdated
Show resolved
Hide resolved
kex-core/src/main/kotlin/org/vorpal/research/kex/util/HackedClassLoader.kt
Outdated
Show resolved
Hide resolved
| @@ -63,6 +63,46 @@ fun getJDKPath(): Path { | |||
|
|
|||
| fun getJavaPath(): Path = Paths.get(System.getProperty("java.home"), "bin", "java").toAbsolutePath() | |||
|
|
|||
| val Config.isMockingEnabled: Boolean | |||
There was a problem hiding this comment.
The idea is that we define the most widely used parameters as extension properties for Config in this file.
Although idea to extract all the mocking parameters into extension properties is not bad, I would move the majority of them into somewhere separate, e.g. into mockUtils.kt file
kex-runner/src/main/kotlin/org/vorpal/research/kex/reanimator/actionsequence/ActionSequence.kt
Outdated
Show resolved
Hide resolved
fixes MockSetField, MockSequence -> MockList
AbdullinAM
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.