Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds minimal poetry config #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JanKoppe
Copy link

I find poetry much more comfortable - takes care of setting up the venv for you (without polluting your PATH), and auto-generates a lockfile for deep dependencies.

Copy link
Contributor

@Kunsi Kunsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, just saw it now.

description = "Configuration management for all VOC systems"
authors = ["c3voc"]

[tool.poetry.dependencies]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to have this import the dependencies from requirements.txt? I'd like to avoid having to update dependencies in two places instead of one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. You would have to 'poetry add ' from the requirements.txt.
But it will only install the latest version of the package.

[tool.poetry]
name = "cm"
version = "0.1.0"
description = "Configuration management for all VOC systems"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically wrong, because bundlewrap only does the event-specific stuff.

@@ -0,0 +1,16 @@
[tool.poetry]
name = "cm"
version = "0.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What gets versioned here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants