Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static checks #208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

static checks #208

wants to merge 2 commits into from
+5 −5

Conversation

kaovilai
Copy link
Contributor

  • don't use Yoda conditions (ST1017)
  • static-check: Remove unused vars

@reasonerjt
Copy link
Contributor

@kaovilai Is it to fix some lint error you run downstream?
I don't have an opinion on "Yoda condition" but it may not be sustainable, i.e. we can't prevent it from happening again.

@kaovilai
Copy link
Contributor Author

Not downstream nor a requirement.. just my ide. So figured I submit a fix here. I can also silence my ide warnings.

mateusoliveira43
mateusoliveira43 approved these changes Aug 6, 2024
View reviewed changes
Copy link

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid this in the future, this needs to be addressed vmware-tanzu/velero#7690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseago sseago sseago approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@mateusoliveira43 mateusoliveira43 mateusoliveira43 approved these changes

@ywk253100 ywk253100 Awaiting requested review from ywk253100

Assignees

@kaovilai kaovilai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaovilai @reasonerjt @sseago @shubham-pampattiwar @mateusoliveira43