refactor: update build.sh command-line arguments
#968
+109
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ClemTheStudent, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@ClemTheStudent, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
tenthirtyam
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Thanks for thr contribution!
A couple of nits:
- Please use English for stdout and comments.
- Please open and enhancement request and link this pull request to the issue per the contributing guidelines.
- Please use conventional commits per the contributing guidelines. See the commit history for examples.
- Please include any testing performed.
|
Marked as draft until CLA is completed. |
ClemTheStudent
added a commit
to ClemTheStudent/packer-examples-for-vsphere
that referenced
this pull request
Sep 19, 2024
tenthirtyam
requested changes
Sep 19, 2024
tenthirtyam
force-pushed
the
develop
branch
2 times, most recently
from
fa689ca
to
e110b24
Compare
- Refactors the `build.sh` script to support operating system selection, distribution, version, and edition via command-line arguments. - Updates the help menu to reflect the new options and parameters. - Implements an `--auto-continue` option to skip manual prompts, enabling smoother automation. Signed-off-by: ClemTheStudent <[email protected]>
tenthirtyam
force-pushed
the
develop
branch
from
0985426
to
12409e2
Compare
tenthirtyam
changed the title
build.sh command-line arguments
|
Rebased from
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
build.shscript to support operating system selection, distribution, version, and edition via command-line arguments.--auto-continueoption to skip manual prompts, enabling smoother automation.Type of Pull Request
type/bugtype/featuretype/refactortype/docstype/chorePlease describe:
Related to Existing Issues
Closes #969
Test and Documentation Coverage
Breaking Changes?