Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

artifacts pipeline and sample plots #147

Open
wants to merge 44 commits into
base: delta
Choose a base branch
from

Commits on Nov 11, 2021

  1. Configuration menu
    Copy the full SHA
    4699ff4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fc1b1b View commit details
    Browse the repository at this point in the history
  3. k8s-scheduler: fix checkstyle/spotbugs warnings

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh authored and amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    99697fc View commit details
    Browse the repository at this point in the history
  4. k8s-scheduler: exclude transitive dependencies

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh authored and amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    d817727 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8b233f7 View commit details
    Browse the repository at this point in the history
  6. k8s-scheduler: rebase with master

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh authored and amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8c286b5 View commit details
    Browse the repository at this point in the history
  7. Modify scheduler_tables.sql so that create table statements can be …

    …parsed by ddlog-sql
    
    Changes:
    - char(N) --> varchar(N) because the DDlog language doesn't support char(N)
    - Remove FK constraints, as neither Calcite nor Presto support this
    - Add types to arrays so they are parseable by Calcite
    
    ----------
    
    All uncommented views in DBSchema pass both H2 and Presto translation
    
    Edits required:
    - select --> select distinct, necessary for both Calcite and Presto
    - remove camelcase column names, as Presto make everything case-insensitive
    - DDlog cannot support LIMIT, which will need to be addressed in the future
    - Remove ';' at the end of some statements, as Presto doesn't like this
    
    TODO:
    - Fix commented-out views in DBSchema, which are a combination of sql->DDlog compiler not supporting some statements, or Calcite doesn't like some of the complex SQL
    
    ----------
    
    All views other than affinity/anti-affinity pass
    
    - Add all columns that are using in the HAVING clause to GROUP BY clause
    - Add array_length functionality to DDlog
    - DDlog only supports array_agg for now, instead of array_agg_distinct
    
    TODO:
    - array_agg_distinct
    - Affinity views
    
    -----------
    
    Move all DDlog SQL updates to separate files, so that we can still run our H2 tests
    
    -----------
    
    Signed-off-by: Amy Tai <[email protected]>
    
    Changes to make SchedulerTest::testSchedulerNodePredicates pass
    
    Summary of changes:
    - New IConnectionPool interface so that we can seamlessly swap DBConnectionPool out for DDlogDBConnectionPool
    - Temporarily comment out OnDuplicateKeyUpdate queries in PodEventsToDatabase and NodeResourceEventHandler, as DDlog backend cannot handle MERGE SQL queries at the moment
    - Inserts into DDlog must be in order of the column declarations in the CREATE TABLE statement
    - Any SQL queries that will eventually hit DDlog must use unqualified names
    - Wherever there is a dslContext.meta.getTables() call (or any dslContext.meta.* function call), for the DDlog backend this must be called against the dslContext that is a class variable within the DDlogJooqProvider. Every other dslContext call (i.e. ones that are used to execute select/insert/etc. queries), should be made against the DSLContext held inside the DDlogDBConnectionPool. These two use cases are differentiated by the two different accessor functions inside IConnectionPool.
    
    Signed-off-by: Amy Tai <[email protected]>
    
    Migrate modifications to scheduler_tables.sql and DBView.java to DDlog versions
    
    testSchedulerNodePredicates and testSpareCapacity both pass.
    
    Signed-off-by: Amy Tai <[email protected]>
    
    testHostPorts passes
    
    Goes with corresponding DDlog patch on vectors (array_agg column type)
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    d08e052 View commit details
    Browse the repository at this point in the history
  8. DDlogDBViews and ddlog_scheduler_tables.sql updates to match the new …

    …spare capacity views that Lalith has
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8e7e5ec View commit details
    Browse the repository at this point in the history
  9. Add identity views for each input table, so that we can query input t…

    …ables on the DDlog side
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    4534cef View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    679536b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4645809 View commit details
    Browse the repository at this point in the history
  12. Changes to make DCM run reasonably with DDlog. WorkloadReplayTest tes…

    …ts seem to work at this commit
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    86b351f View commit details
    Browse the repository at this point in the history
  13. Make DDlog work with Autoscope "_sorted" views

    - "_augmented" views still don't work because they require preemption views from DDlogDBViews, which were commented out hitherto
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    bae6e8e View commit details
    Browse the repository at this point in the history
  14. Premption views compile succesfully, AutoScope "_augmented" also seem…

    … to work
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    0196d98 View commit details
    Browse the repository at this point in the history
  15. Remove 2x rebuild of the DDlog program, as this causes the runtime to…

    … use a stale DDlog API.
    
    Instead, don't compileAndLoad until the very last time (after Autoscope)
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    6a16263 View commit details
    Browse the repository at this point in the history
  16. Some nits: timing, remove limit from Autoscope

    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e92067a View commit details
    Browse the repository at this point in the history
  17. Add hand-optimized DDlog programs

    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    cf36222 View commit details
    Browse the repository at this point in the history
  18. Add functionality in benchmarking code to optionally provide a hand-o…

    …ptimized DDlog program file. In that case, /tmp/program.dl is not compiled using sql-ddlog compiler. Instead, we just copy over contents of the hand-optimized file into /tmp/program.dl.
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    1 Configuration menu
    Copy the full SHA
    03b6379 View commit details
    Browse the repository at this point in the history
  19. Move hand-optimized DDlog programs to src/main/resources

    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    0b7ebe0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Modify Translator signature to match new DDlog Java API

    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    57710c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e01aca7 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. k8s-scheduler: prefix all DB dumps with debug_

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    0a33316 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    676c865 View commit details
    Browse the repository at this point in the history
  3. k8s-scheduler: fix debug-mode flag

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    5c9dc09 View commit details
    Browse the repository at this point in the history
  4. k8s-scheduler: use select * form in DebugUtils.dbDump()

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    7595eca View commit details
    Browse the repository at this point in the history
  5. k8s-scheduler: fix checkstyle and spotbugs issues

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3fe428b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8cb154a View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. At the beginning of SchedulerTest, compile the DDlog program w Scoped…

    … Views once, so that we never have to compile it again with each of the CartesianProductTests.
    
    We also temporarily change the Scheduler constructor to add AutoScoped views to DDlog, even if the Scheduler isn't running in AutoScoped mode. This is so that we can use the same DDlog program (with scoping) for non-scoped tests as well.
    
    Need to fix this eventually, as for real tests/workloads, we might want to turn off Autoscoping.
    
    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    2b0cc5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3416c87 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. k8-scheduler: checkpoint

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    c316205 View commit details
    Browse the repository at this point in the history
  2. k8-scheduler: temporary workaround for spare capacity while ddlog-lef…

    …t-joins are brewing
    
    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    0d2b066 View commit details
    Browse the repository at this point in the history
  3. k8s-scheduler: workaround until DDLJP.fetchTable() works correctly wi…

    …th identity views
    
    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    5a02a96 View commit details
    Browse the repository at this point in the history
  4. k8s-scheduler: requeue() should update by pod.uid. testRequeue() now …

    …passes.
    
    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    d256534 View commit details
    Browse the repository at this point in the history
  5. Add LIMIT back into pod view

    Signed-off-by: Amy Tai <[email protected]>
    amytai committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    c503641 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. k8s-scheduler: avoid some circular dependencies

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    040e788 View commit details
    Browse the repository at this point in the history
  2. k8s-scheduler: simplify DDlog connection initialization

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    6750477 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    60f3c23 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37999ec View commit details
    Browse the repository at this point in the history
  5. k8s-scheduler: make testPreempt() pass

    Signed-off-by: Lalith Suresh <[email protected]>
    lalithsuresh committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    e640bbd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    40fd3ec View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. artifacts pipeline and sample plots

    Signed-off-by: Athinagoras Skiadopoulos <[email protected]>
    askiad committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    5e62be4 View commit details
    Browse the repository at this point in the history
  2. removing sample artifact outputs

    Signed-off-by: Athinagoras Skiadopoulos <[email protected]>
    askiad committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    160c200 View commit details
    Browse the repository at this point in the history
  3. adding side-by-side barplots for different schedulers

    Signed-off-by: Athinagoras Skiadopoulos <[email protected]>
    askiad committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    7e16304 View commit details
    Browse the repository at this point in the history
  4. restore SchedulerTest

    Signed-off-by: Athinagoras Skiadopoulos <[email protected]>
    askiad committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    2d4fd1f View commit details
    Browse the repository at this point in the history