Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix incorrect llava next feature size calculation #8496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zyddnys
Copy link

@zyddnys zyddnys commented Sep 15, 2024

The old code produces incorrect feature size and leads to

Attempted to assign XXX = XXX multimodal tokens to YYY placeholders

An image with size 700x840 can trigger this

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

DarkLight1337 commented Sep 16, 2024

Can you show the code you used to initialize vLLM and pass the image into the model? I cannot repro this issue. Also, can you run collect_env.py to show the details about your environment?

@DarkLight1337 DarkLight1337 changed the title fix incorrect llava next feature size calculation [Bugfix] Fix incorrect llava next feature size calculation Sep 17, 2024
@zyddnys
Copy link
Author

zyddnys commented Sep 19, 2024

this only happen to llava next models using siglip so400m as text encoder

@DarkLight1337
Copy link
Member

Which HF repo is this model from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants