Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Clarity: Parsing Rewrite #16

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

vixalien
Copy link
Owner

Hello everyone, I'm launching Project Clarity, which will be a major rewrite of the application and will probably lead to our first v1 (#2).

There's a couple of reasons, and I'll list a few starting from the most heavy ones:

  1. The current way we parse content was inspired by https://github.com/sigma67/ytmusicapi and relies heavily on guesswork. We parse blindly, expecting JSON to have a certain structure, and in the case of errors, we throw a weird error that usually only myself can decode. The new version of muse will "know" about the structure of the various data types provided by YouTube music's API and will parse them accordingly.
  2. The current source has no tests :/
  3. The current version has poor documentation, and users sometimes get confused.
  4. The current version has many exported symbols, which makes the library users confused.
  5. You can find the same parsers implemented many times elsewhere
  6. The nav.ts file is getting too huge imo, and is almost incomprehensible

@vixalien vixalien changed the title Project Clarity: Parsing overhaul Project Clarity: Parsing Rewrite Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant