Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadertools: Lighting module UBO #2206

Merged
merged 7 commits into from
Aug 22, 2024
Merged

shadertools: Lighting module UBO #2206

merged 7 commits into from
Aug 22, 2024

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Aug 22, 2024

Cherry pick of: #2159, #2166, #2169, #2170, #2171 & #2172

@ibgreen I had a quick play with the WebGPU variant of tutorials/lighting, but without success:

@fragment
fn fragmentMain(inputs: FragmentInputs) -> @location(0) vec4<f32> {
  return vec4<f32>(inputs.fragPosition, 1);
  var surfaceColor = vec3(1.0);
  surfaceColor = lighting_getLightColor2(surfaceColor, app.eyePosition, inputs.fragPosition, normalize(inputs.fragNormal));
  return vec4<f32>(surfaceColor, 1);
}

examples/tutorials/lighting/app.ts Outdated Show resolved Hide resolved
examples/tutorials/lighting/app.ts Show resolved Hide resolved
@felixpalmer felixpalmer merged commit 876df03 into master Aug 22, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/lighting-ubo-2 branch August 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants