feat(core): Address feedback on BufferLayout #1799
Conversation
| stepMode: bufferLayout.stepMode, | ||
| vertexFormat: bufferLayout.format, | ||
| // If offset is needed, use `attributes` field. | ||
| byteOffset: 0, |
There was a problem hiding this comment.
Thinking of the user-supplied binary buffer case in deck.gl - does this mean we have to format bufferLayout differently depending on whether offset is 0?
There was a problem hiding this comment.
I would assume that a framework like deck.gl always uses the extended form with attributes: in which offset is available (even when only having one attribute per buffer). Of course if deck.gl exposes the bufferLayout to deck.gl end users, then users have the option of using the short form when they don't need any customization. i.e. offsets, interleaving or custom byte strides.
At this point I am really just including format on the top level as a short-hand to make small luma examples less verbose and intimidating.
Perhaps it is better to not even offer that shorthand. But... one step at a time, this PR clears up a lot of the overlap that was causing confusion, and as long as deck is only using attributes array should be objectively better. Not hard to drop the shorthand if we find it causes more pain than it is worth.
For #
Background
Change List