Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webgl): Enforce WebGPU style topology #1781

Merged
merged 1 commit into from
Aug 19, 2023
Merged

feat(webgl): Enforce WebGPU style topology #1781

merged 1 commit into from
Aug 19, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Aug 18, 2023

For #

Background

  • Continuous cleanup: Mixed usage of WebGL numeric constants and WebGPU string constants is getting messy.

Change List

  • Replace al GL constant based drawMode parameters with topology strings
  • Instead of preventing use, now provides named webgl-only constants for draw modes (topologies) and vertex formats, such as triangle-fan-webgl and unorm8x3-webgl
  • Calls out lack of portability while allowing apps to adopt new API.

Notes

  • will require a quick pass in the deck.gl integration branch as well.

@ibgreen ibgreen merged commit bc60ada into master Aug 19, 2023
1 of 2 checks passed
@ibgreen ibgreen deleted the ib.topology branch August 19, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants