Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webgl): Export legacy BufferWithAccessor #1773

Merged
merged 1 commit into from
Aug 5, 2023
Merged

feat(webgl): Export legacy BufferWithAccessor #1773

merged 1 commit into from
Aug 5, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Aug 5, 2023 •
edited
Loading

For #

Background

  • The legacy buffer class with the accessor is much too complicated and needs to be streamlined to allow WebGPU support.
  • But the impact on applications will be too high, so keep the class for now and export it from the webgl module (instead of api).

Change List

@ibgreen ibgreen merged commit f569892 into master Aug 5, 2023
1 check passed
@ibgreen ibgreen deleted the ib/buffer-with-accessor branch August 5, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen