feat(constants): Drop default export to improve ES module compatibility

CHANGELOG.md

@@ -1095,7 +1095,7 @@
 - Ocular based website: initial directory (#564)
 - Adopt new underscore convention for experimental exports (#563)
 - Make polyfills for webgl1 optional (Dist Size Reduction) (#554)
-- Update code to import GL from luma.gl/constants (#556)
+- Update code to import {GL} from luma.gl/constants (#556)
 - Code cleanup (#559)
 - Doc Improvements (#558)
 

dev-modules/babel-plugin-inline-webgl-constants/README.md

@@ -21,7 +21,7 @@ const max = 34921;
 #### in
 
 ```typescript
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 ...
 const max = GL.MAX_VERTEX_ATTRIBS;
 ```

dev-modules/babel-plugin-inline-webgl-constants/index.js

@@ -1,5 +1,5 @@
 /* eslint-disable no-console, import/no-unresolved */
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 
 const COLOR_RESET = '\x1b[0m';
 const COLOR_YELLOW = '\x1b[33m';

docs/api-reference-v8/constants/README.md

@@ -10,7 +10,7 @@ a (big) enum `GL` that contains all WebGL constants (i.e. the OpenGL API constan
 ## Usage
 
 ```typescript
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 const type = GL.POINTS;
 ```
 

docs/api-reference-v8/webgl-legacy/context/context-properties.md

@@ -15,7 +15,7 @@ luma.gl provides several helper functions for testing properties of a WebGL cont
 ````
 Check a certain limit (whether through an extension under WebGL 1 or through WebGL 2)
 ```typescript
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {getContextLimits} from '@luma.gl/gltools';
 const limits = getContextLimits(gl);
 if (limits[GL.MAX_COLOR_ATTACHMENTS] > 0) { // it will be 0 for WebGL 1

docs/api-reference/api/device-limits.mdx

@@ -69,7 +69,7 @@ the luma.gl Device APIs. You can access "raw" WebGL extensions and limits direct
 A luma.gl `WebGLDevice` extracts an object that contains all "raw" WebGL limits.
 
 ```typescript
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WebGLDevice} from '@luma.gl/webgl';
 
 const webglDevice = device instanceof WebGLDevice ? device as WebGLDevice: null;

docs/upgrade-guide/README.md

@@ -364,7 +364,7 @@ luma.gl v6.0 removes a number of previously deprecated symbols. luma.gl will now
 
 | Removed symbol     | Replacement                          | Reason for change                                       |
 | ------------------ | ------------------------------------ | ------------------------------------------------------- |
-| `GL`               | `import GL from 'luma.gl/constants'` | Bundle size reduction (by making this import optional). |
+| `GL`               | `import {GL} from 'luma.gl/constants'` | Bundle size reduction (by making this import optional). |
 | `glGet(name)`      | `glGet(gl, name)`                    | Bundle size reduction (Was deprecated in v5.3)          |
 | `glKey(value)`     | `glKey(gl, value)`                   | Bundle size reduction (Was deprecated in v5.3)          |
 | `glKeyType(value)` | `glKeyType(gl, value)`               | Bundle size reduction (Was deprecated in v5.3)          |
@@ -438,7 +438,7 @@ v5.3 deprecates a number of symbols. It is recommended that you replace their us
 
 | Deprecated symbol | Replacement                          | Reason                      |
 | ----------------- | ------------------------------------ | --------------------------- |
-| `GL`              | `import GL from 'luma.gl/constants'` | Bundle size concerns        |
+| `GL`              | `import {GL} from 'luma.gl/constants'` | Bundle size concerns        |
 | `deleteGLContest` | `destroyGLContext`                   | API Audit: Naming alignment |
 | `pollContext`     | `pollGLContext`                      | API Audit: Naming alignment |
 

docs/upgrade-guide/upgrade-v9.md

@@ -40,17 +40,22 @@ The ground-up focus on TypeScript and strong typing in luma.gl v9 should create
 
 Detailed notes
 
-- `@luma.gl/gltools` (removed)
-    - The WebGL context functions (`createGLContext` etc), have been moved to the new `WebGLDevice` and `CanvasContext` classes.
-    - It also contains the classic luma.gl WebGL 2 classes (`Program`, `Texture2D`) etc that used to be improved from `@luma.gl/webgl`. However these classes are now just exposed for backwards compatibility and should gradually be relaced.
-    - To simplify gradual introduction of the new v9 API, all APIs in `@luma.gl/Webgl-legacy` have been updated to optionally accept a `Device` parameter instead of a `WebGLRenderingContext`
-- `@luma.gl/core` module is "in transition":
+**`@luma.gl/core`** module is "in transition":
     - in v9, the core module still exports the deprecated v8 classes from `@luma.gl/gltools` (so that applications can gradually start moving to the v10 API).
     - WebGL class exports are deprecated and should be imported directly from `@luma.gl/webgl-legacy`.
-- `@luma.gl/constants` module remains but is no longer needed by applications:
+
+**`@luma.gl/experimental`**
+    - Scene graph exports (`ModelNode`, `GroupNode`, `ScenegraphNode`) has been moved into `@luma.gl/engine`.
+
+**`@luma.gl/constants`** module remains but is no longer needed by applications:
     - WebGL-style numeric constants (`GL.` constants) are no longer used in the public v9 API.
     - Instead, the luma.gl v9 API contains strictly types WebGPU style string constants
+    - Breaking change: Constants are now exported via a named export rather than a default export (for better ES modules compatibility): `import GL from @luma.gl/constants` => `import {GL} from @luma.gl/constants`.
 
+**`@luma.gl/gltools`** (removed)
+    - The WebGL context functions (`createGLContext` etc), have been moved to the new `WebGLDevice` and `CanvasContext` classes.
+    - It also contains the classic luma.gl WebGL 2 classes (`Program`, `Texture2D`) etc that used to be improved from `@luma.gl/webgl`. However these classes are now just exposed for backwards compatibility and should gradually be relaced.
+    - To simplify gradual introduction of the new v9 API, all APIs in `@luma.gl/Webgl-legacy` have been updated to optionally accept a `Device` parameter instead of a `WebGLRenderingContext`
 
 ### Feature-level changes
 

docs/whats-new.md

@@ -55,10 +55,10 @@ Note that adoption of the new v9 luma.gl API will require existing luma.gl v8 ap
 - Exports `WebGLDevice`, a WebGL / WebGL 2 backend implementation of the luma.gl API (`@luma.gl/api`). 
 - Importing this module enables the application to create `Device`s of type `'webgl2'` or `'webgl'`.
 
-#### `@luma.gl/constants` (deprecated)
+#### `@luma.gl/constants` (breaking changes, deprecated)
 
-- The `@luma.gl/constants` module is still available, but is no longer needed by luma.gl v9 applications.
-- For convenience, the {`GL`} export is also available in the `@luma.gl/webgl-legacy` module.
+- The `@luma.gl/constants` module is still available, but is now considered an internal luma.gl module as GL constants are no longer exposed in the luma.gl v9 API.
+- Constants are now exported via a named export `GL` rather than a default export (for better ES modules compatibility).
 
 #### `@luma.gl/debug`
 

modules-wip/experimental/src/gltf/gltf-material-parser.ts

@@ -1,6 +1,6 @@
 import type {Device, Texture, Binding, Parameters} from '@luma.gl/api';
 import {log} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {PBREnvironment} from './pbr-environment';
 
 /* eslint-disable camelcase */

modules-wip/experimental/src/gpgpu/point-in-polygon/gpu-point-in-polygon.ts

@@ -1,5 +1,5 @@
 import {assert} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Buffer, Texture2D} from '@luma.gl/webgl-legacy';
 import {Transform} from '@luma.gl/webgl-legacy';
 import {textureFilterModule} from './texture-filter';

modules-wip/webgl-legacy/src/classic/context-api.ts

@@ -4,7 +4,7 @@
 
 /* eslint-disable quotes */
 import type {Device, DeviceProps} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WebGLDevice} from '@luma.gl/webgl';
 import {DEPRECATED_FEATURES, DEPRECATED_TO_CLASSIC_FEATURES} from './features';
 

modules-wip/webgl-legacy/src/classic/copy-and-blit.ts

@@ -1,6 +1,6 @@
 // luma.gl, MIT license
 import {log, assert, Texture, Framebuffer} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WEBGLTexture, WEBGLFramebuffer, assertWebGL2Context} from '@luma.gl/webgl';
 import {withParameters} from '@luma.gl/webgl';
 import {flipRows, scalePixels} from '../webgl-utils/typed-array-utils';

modules-wip/webgl-legacy/src/classic/framebuffer.ts

@@ -1,6 +1,6 @@
 import type {FramebufferProps} from '@luma.gl/api';
 import {Device, log, assert} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {getWebGL2Context, assertWebGL2Context} from '@luma.gl/webgl';
 import {WebGLDevice, WEBGLFramebuffer, WEBGLTexture, WEBGLRenderbuffer} from '@luma.gl/webgl';
 import {getKey} from '../webgl-utils/constants-to-keys';

modules-wip/webgl-legacy/src/classic/program.ts

@@ -2,7 +2,7 @@
 
 import type {Device, RenderPipelineProps, RenderPipelineParameters, RenderPass} from '@luma.gl/api';
 import {log, assert, uid, cast, Shader} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {parseUniformName, getUniformSetter} from './uniforms';
 import ProgramConfiguration from './program-configuration';
 import {copyUniform, checkUniformValues} from './uniforms';

modules-wip/webgl-legacy/src/classic/renderbuffer.ts

@@ -1,6 +1,6 @@
 /* eslint-disable no-inline-comments */
 import type {Device} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WebGLDevice, WEBGLRenderbuffer, RenderbufferProps, convertGLToTextureFormat} from '@luma.gl/webgl';
 
 export type ClassicRenderbufferProps = Omit<RenderbufferProps, 'format'> & {

modules-wip/webgl-legacy/src/classic/shader.ts

@@ -1,6 +1,6 @@
 // luma.gl, MIT license
 import {assert, uid, ShaderProps} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {getShaderInfo} from '@luma.gl/shadertools';
 import {WebGLDevice, WEBGLShader} from '@luma.gl/webgl';
 import {assertWebGLContext} from '@luma.gl/webgl';

modules-wip/webgl-legacy/src/classic/texture-cube.ts

@@ -1,5 +1,5 @@
 import {Device} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import Texture, {TextureProps} from './texture';
 
 /**

modules-wip/webgl-legacy/src/classic/texture.ts

@@ -1,5 +1,5 @@
 import {Device, TextureFormat, TextureProps, assert} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {isWebGL2} from '@luma.gl/webgl';
 import {getKey, getKeyValue} from '../webgl-utils/constants-to-keys';
 import {WebGLDevice, WEBGLTexture} from '@luma.gl/webgl';

modules-wip/webgl-legacy/src/classic/transform-feedback.ts

@@ -1,5 +1,5 @@
 import {Device, ResourceProps, log, isObjectEmpty} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WebGLDevice, WebGLResource} from '@luma.gl/webgl';
 import {isWebGL2} from '@luma.gl/webgl';
 import Buffer from './buffer';

modules-wip/webgl-legacy/src/classic/uniforms.ts

@@ -1,5 +1,5 @@
 import {log, assert} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WEBGLTexture, WEBGLFramebuffer, WEBGLRenderbuffer} from '@luma.gl/webgl';
 
 type NumberUniformInfo = {

modules-wip/webgl-legacy/src/classic/vertex-array-object.ts

@@ -1,6 +1,6 @@
 import type {NumberArray} from '@luma.gl/api';
 import {assert, getScratchArray, fillArray, ResourceProps} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {getBrowser} from '@probe.gl/env';
 import {WebGLDevice} from '@luma.gl/webgl';
 import {assertWebGL2Context, isWebGL2} from '@luma.gl/webgl';

modules-wip/webgl-legacy/src/classic/vertex-array.ts

@@ -1,6 +1,6 @@
 import {log, assert, AttributeBinding, TypedArray} from '@luma.gl/api';
 import {ClassicBuffer, WEBGLBuffer, AccessorObject} from '@luma.gl/webgl';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import Accessor from './accessor';
 import Program from './program';
 import ProgramConfiguration from './program-configuration';

modules-wip/webgl-legacy/src/engine/classic-clip-space.ts

@@ -1,6 +1,6 @@
 // ClipSpace
 import {Device} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Geometry} from '@luma.gl/engine';
 import Model, {ClassicModelProps as ModelProps} from './classic-model';
 

modules-wip/webgl-legacy/src/engine/classic-model.ts

@@ -1,7 +1,7 @@
 // luma.gl, MIT license
 import type {RenderPipelineParameters, Shader} from '@luma.gl/api';
 import {Device, Buffer, log, isObjectEmpty, uid, assert} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WebGLDevice, GLParameters} from '@luma.gl/webgl';
 import type {ProgramProps} from '../classic/program';
 

modules-wip/webgl-legacy/src/engine/model-utils.ts

@@ -1,5 +1,5 @@
 import {assert} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Buffer} from '@luma.gl/webgl';
 
 // Support for mapping new geometries with glTF attribute names to "classic" luma.gl shader names

modules-wip/webgl-legacy/src/transform/texture-transform.ts

@@ -1,6 +1,6 @@
 // luma.gl, MIT license
 
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Device, Framebuffer} from '@luma.gl/api';
 
 import {

modules-wip/webgl-legacy/src/transform/transform.ts

@@ -2,7 +2,7 @@
 
 import {Device, assert, isObjectEmpty, Framebuffer} from '@luma.gl/api';
 import {getShaderInfo, getPassthroughFS} from '@luma.gl/shadertools';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {WebGLDevice, GLParameters} from '@luma.gl/webgl';
 // import {AccessorObject} from '@luma.gl/webgl';
 

modules-wip/webgl-legacy/src/webgl-utils/format-utils.ts

@@ -1,5 +1,5 @@
 import {assert} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 
 // Returns number of components in a specific readPixels WebGL format
 export function glFormatToComponents(format) {

modules-wip/webgl-legacy/src/webgl-utils/typed-array-utils.ts

@@ -1,6 +1,6 @@
 // luma.gl, MIT license
 
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 
 const ERR_TYPE_DEDUCTION = 'Failed to deduce GL constant from typed array';
 

modules-wip/webgl-legacy/test/classic/accessor.spec.ts

@@ -1,5 +1,5 @@
 import test from 'tape-promise/tape';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Accessor} from '@luma.gl/webgl-legacy';
 import {DEFAULT_ACCESSOR_VALUES} from '@luma.gl/webgl/classic/accessor';
 

modules-wip/webgl-legacy/test/classic/buffer.spec.ts

@@ -1,4 +1,4 @@
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Buffer, isWebGL} from '@luma.gl/webgl-legacy';
 import test from 'tape-promise/tape';
 

modules-wip/webgl-legacy/test/classic/context/limits.spec.ts

@@ -1,7 +1,7 @@
 // luma.gl, MIT license
 import { WebGLLimits } from '@luma.gl/webgl';
 import {getKey, getContextInfo} from '@luma.gl/webgl-legacy';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import test from 'tape-promise/tape';
 
 import {fixture} from 'test/setup';

modules-wip/webgl-legacy/test/classic/copy-and-blit.spec.ts

@@ -1,5 +1,5 @@
 import test from 'tape-promise/tape';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Framebuffer, Renderbuffer, Texture2D, Buffer, getKey} from '@luma.gl/webgl-legacy';
 import {fixture} from 'test/setup';
 import {readPixelsToArray, readPixelsToBuffer, copyToTexture, blit} from '@luma.gl/webgl-legacy';

modules-wip/webgl-legacy/test/classic/framebuffer.spec.ts

@@ -1,6 +1,6 @@
 /* eslint-disable max-len */
 import test from 'tape-promise/tape';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Framebuffer, Renderbuffer, Texture2D} from '@luma.gl/webgl-legacy';
 import {fixture} from 'test/setup';
 

modules-wip/webgl-legacy/test/classic/program-configuration.spec.ts

@@ -1,5 +1,5 @@
 import test from 'tape-promise/tape';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Program} from '@luma.gl/webgl-legacy';
 import ProgramConfiguration from '@luma.gl/webgl-legacy/classic/program-configuration';
 import {fixture} from 'test/setup';

modules-wip/webgl-legacy/test/classic/query.spec.ts

@@ -2,7 +2,7 @@
 import test from 'tape-promise/tape';
 import {Query} from '@luma.gl/webgl-legacy';
 // import util from 'util';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {fixture} from 'test/setup';
 
 function pollQuery(query, t) {

modules-wip/webgl-legacy/test/classic/texture-cube.spec.ts

@@ -1,6 +1,6 @@
 import test from 'tape-promise/tape';
 import {TextureCube} from '@luma.gl/webgl-legacy';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 
 import {fixture} from 'test/setup';
 

modules-wip/webgl-legacy/test/classic/texture.spec.ts

@@ -2,7 +2,7 @@
 import test from 'tape-promise/tape';
 import {fixture} from 'test/setup';
 
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {isWebGL2} from '@luma.gl/webgl-legacy';
 import {Buffer, Texture2D, getKey, readPixelsToArray} from '@luma.gl/webgl-legacy';
 

modules-wip/webgl-legacy/test/classic/transform-feedback.spec.ts

@@ -1,5 +1,5 @@
 import {glsl} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {TransformFeedback, Buffer} from '@luma.gl/webgl-legacy';
 // TODO - tests shouldn't depend on higher level module?
 import {Model} from '@luma.gl/webgl-legacy';

modules-wip/webgl-legacy/test/classic/uniform-buffer-layout.spec.ts

@@ -2,7 +2,7 @@
 
 import test from 'tape-promise/tape';
 import {glsl} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {UniformBufferLayout, Buffer, Program} from '@luma.gl/webgl-legacy';
 // TODO - tests shouldn't depend on higher level module?
 import {Transform} from '@luma.gl/webgl-legacy';

modules-wip/webgl-legacy/test/classic/uniform-cache-test-cases.ts

@@ -1,4 +1,4 @@
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 
 export const CACHING_TEST_CASES = [
   {

modules-wip/webgl-legacy/test/engine/model.spec.ts

@@ -1,7 +1,7 @@
 import test from 'tape-promise/tape';
 import {webgl1Device} from '@luma.gl/test-utils';
 
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {luma} from '@luma.gl/api';
 // TODO - Model test should not depend on Cube
 import {ClassicModel as Model, ProgramManager} from '@luma.gl/webgl-legacy';

modules-wip/webgl-legacy/test/transform/transform.spec.ts

@@ -2,7 +2,7 @@ import test from 'tape-promise/tape';
 import {webgl1Device, webgl2Device} from '@luma.gl/test-utils';
 
 import {luma, glsl} from '@luma.gl/api';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 import {Transform} from '@luma.gl/webgl-legacy';
 import {Buffer, Texture2D, setParameters, getParameters} from '@luma.gl/webgl-legacy';
 import {TypedArray} from 'modules/api/dist';

modules-wip/webgl-legacy/test/webgl-utils/texture-utils.spec.ts

@@ -2,7 +2,7 @@ import test from 'tape-promise/tape';
 import {cloneTextureFrom} from '@luma.gl/webgl-legacy/webgl-utils/texture-utils';
 import {Texture2D} from '@luma.gl/webgl-legacy';
 import {fixture} from 'test/setup';
-import GL from '@luma.gl/constants';
+import {GL} from '@luma.gl/constants';
 
 test('texture-utils#cloneTextureFrom', (t) => {
   const {gl} = fixture;