Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix issue with setting 0 or false values #1766

Commits on Jul 15, 2023

  1. fix: 🐛 Fix issue with setting 0 or false values

    The change involves replacing the logical OR operator (`||`) with the
    nullish coalescing operator (`??`) in the `_applyUniforms()` method.
    This modification addresses a specific issue where 0 or false values
    were not being correctly assigned. By using the nullish coalescing
    operator, the code ensures that if the value of `this.uniforms[name]` is
    either 0 or false, it will be properly assigned as the value for
    `value`. This change enhances the accuracy and reliability of the code
    by handling these specific cases effectively.
    
    ✅ Closes: #1741
    Seungup committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    050ff5a View commit details
    Browse the repository at this point in the history