Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [VIOL-996] Segment analytics happy flow #166

Merged
merged 11 commits into from
Oct 3, 2023

Conversation

sudoFerraz
Copy link
Contributor

Your PR title must follow conventional commits, and should start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Example commit messages:

  • feat: adds support for gnosis safe wallet
  • fix: removes a polling memory leak
  • chore: bumps redux version

Other things to note:

  • Please describe the change using verb statements (ex: Removes X from Y)
  • PRs with multiple changes should use a list of verb statements
  • Add any relevant unit / integration tests
  • Changes will be previewable via vercel. Non-obvious changes should include instructions for how to reproduce them

.env.k8s.mauve-dev Outdated Show resolved Hide resolved
@henrik-web3
Copy link
Contributor

Code looks good already, question around using the same segment write key across environments?

src/components/analytics/index.ts Outdated Show resolved Hide resolved
src/lib/hooks/swap/useSendSwapTransaction.tsx Outdated Show resolved Hide resolved
@sudoFerraz sudoFerraz merged commit 3686513 into main Oct 3, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants