Skip to content

Commit

Permalink
fix: fix order of meta merging (fix #1458)
Browse files Browse the repository at this point in the history
  • Loading branch information
brillout committed Jan 25, 2024
1 parent cee0dfe commit a1101c1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ function isDefiningPageConfig(configName: string): boolean {

function getConfigDefinitions(interfaceFilesRelevant: InterfaceFilesByLocationId): ConfigDefinitionsIncludingCustom {
const configDefinitions: ConfigDefinitionsIncludingCustom = { ...configDefinitionsBuiltIn }
Object.entries(interfaceFilesRelevant).forEach(([_locationId, interfaceFiles]) => {
Object.entries(interfaceFilesRelevant).reverse().forEach(([_locationId, interfaceFiles]) => {

This comment has been minimized.

Copy link
@gajus

gajus Jan 25, 2024

Is this going to fix a scenario where we have nested pages?

/a/b/c/...

and b has different meta than the surrounding pages?

This comment has been minimized.

Copy link
@brillout

brillout Jan 25, 2024

Author Member

Yes

interfaceFiles.forEach((interfaceFile) => {
const configMeta = interfaceFile.fileExportsByConfigName['meta']
if (!configMeta) return
Expand Down

0 comments on commit a1101c1

Please sign in to comment.