add com.microsoft.playready.recommendation as a recognised key system #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -348,6 +348,7 @@ const standardizeKeySystemOptions = (keySystem, keySystemOptions) => { | |||
| } | |||
|
|
|||
| const isFairplay = isFairplayKeySystem(keySystem); | |||
| const isPlayready = keySystem === 'com.microsoft.playready' || keySystem === 'com.microsoft.playready.recommendation'; | |||
There was a problem hiding this comment.
Should this include the recommendation.3000 variant as well?
There was a problem hiding this comment.
Not in this state. It should be something like:
const isPlayready = [
'com.microsoft.playready',
'com.microsoft.playready.recommendation',
'com.microsoft.playready.recommendation.3000'
].includes(keySystem)'
or a little bit less safe keySyste.startsWith('com.microsoft.playready') for .3000 to work. I wanted to add that up but I never got to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
com.microsoft.playready.recommendationas a recognised key system. The keysystems behave almost identically. Function getSupportedKeySystem is then dependant on the name of the key system so there shouldn't be any changes needed there.I wanted to add a test that would check that both of the key systems to go through
defaultFairplayGetCertificate(), but there is no test that check getCeritificate for any key system.