Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent key errors from being emitted twice #6704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent key errors from being emitted twice #6704

wants to merge 1 commit into from

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 19, 2024 •
edited
Loading

This PR will...

Removes duplicate catch() handlers added to keySessionContextPromise.
Only handle license renewal error if no longer listening to license status as part of keyUsablePromise.

Why is this Pull Request needed?

Removes duplicate catch() handlers added to keySessionContextPromise and prevents error handling from running before licenseStatus error is caught emitting the error again.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch
Catch keySessionContextPromise once and only handle license renewal e…
9c3df8c 
…rror if no longer listening to license status as part of keyUsablePromise

Resolves #6701
Replaces #6703
@robwalch robwalch added this to the 1.6.0 milestone Sep 19, 2024
@robwalch robwalch mentioned this pull request Sep 19, 2024
Closed
3 tasks
@robwalch robwalch changed the title … Prevent key errors from being emitted twice Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackPu JackPu JackPu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Emit keySystemLicenseRequestFailed twice if we block the license
2 participants
@robwalch @JackPu