Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support of unknown CODECS #6620

Draft
wants to merge 2 commits into
base: feature/interstitials
Choose a base branch
from

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 7, 2024

This PR will...

  • Use multivariant playlist CODECS when mp4 parsed codec is incomplete
  • Support unknown codec as video or audio with passing isTypeSupported checks

Why is this Pull Request needed?

Adds support for playback of audio and video codecs not indexed in utils/codecs or not parsed completely from mp4 init segment so long as a supported CODECS value is provided.

Are there any points in the code the reviewer needs to double check?

Depends on changes in "feature/interstitials" #6591. Will rebase and take out of draft status once merged.

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Aug 7, 2024
@robwalch robwalch marked this pull request as draft August 7, 2024 21:45
@robwalch robwalch requested a review from itsjamie August 13, 2024 19:17
@robwalch robwalch force-pushed the feature/unknown-codec-support branch from 59222d4 to f073588 Compare August 15, 2024 19:28
robwalch and others added 2 commits September 17, 2024 13:29
Support unknown codec as video or audio with passing isTypeSupported checks
…s with video and audio only input

Add codecs-helper to fill in AV1 codec string missing parameters required by MediaCapabilities decodingInfo checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant