[hotfix] Fix buf generation errors #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: The runtime checks make sure that the protobuf version in python is always higher than the compiler's version. So I have to pin them much higher than expected
Protoletariat, a tool we use to fix protobuf's terrible import structure, hasn't been updated in over a year.
Protobuf's new version includes a runtime check.
We couldn't generate the appropriate code to use with the runtime because we couldn't update protoletariat, even though it works with the newest version of protobuf (anecdotally).
So this PR simply overrides the protobuf version the best we can. since poetry doesn't allow for dependency overrides, I just added a pip install step after the normal install to make it work.