Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-2899: Clean up data client API code samples #729

Merged
merged 8 commits into from
Sep 19, 2024
Merged

DOCS-2899: Clean up data client API code samples #729

merged 8 commits into from
Sep 19, 2024

Conversation

sguequierre
Copy link
Contributor

  • tested all of these and found some issues
  • incorporating fixes -- will be mirrored in docs

@sguequierre sguequierre requested a review from a team as a code owner September 13, 2024 15:33
@sguequierre sguequierre mentioned this pull request Sep 13, 2024
Merged
njooma
njooma approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this one

npentrel
npentrel requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging for a bit please

@sguequierre sguequierre merged commit abe0099 into viamrobotics:main Sep 19, 2024
12 checks passed
@sguequierre sguequierre deleted the DOCS-2899/data-client-qa branch September 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@npentrel npentrel npentrel approved these changes

@gloriacai01 gloriacai01 Awaiting requested review from gloriacai01 gloriacai01 is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sguequierre @njooma @npentrel