-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff to lint/format/isort #476
Open
maximpertsov
wants to merge
21
commits into
viamrobotics:main
Choose a base branch
from
maximpertsov:ruff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27,450
−11,149
Open
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d3c0f0a
install ruff
maximpertsov 4a32610
configure linter
maximpertsov 90b5f25
ignore lint on one lint for now
maximpertsov 41ce1ef
use ruff to lint
maximpertsov 72a9871
intentional unformat/unsort
maximpertsov 1da915f
Revert "intentional unformat/unsort"
maximpertsov 07a3fa1
sort change
maximpertsov e7b8bb3
use ruff to format and sort
maximpertsov 0189e48
use same configs
maximpertsov 6ac6fa1
reconfigure
maximpertsov f036b61
reconfigure more
maximpertsov 94b7b9a
too much
maximpertsov b56e0d9
remove flake/black/isort configs
maximpertsov dc34d42
noqa specific rule
maximpertsov 3055c45
Merge branch 'main' into ruff
maximpertsov 92bfad8
fix lock
maximpertsov b14fd6d
merge 'main'
maximpertsov eb99704
ignore unused import errors
maximpertsov 18256af
use importlib to check if numpy is installed
maximpertsov 82f250d
format
maximpertsov 9f7d007
fixup type ignores post-format
maximpertsov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ class ResourceCreatorRegistration: | |
"""A function that can create a resource given a mapping of dependencies (``ResourceName`` to ``ResourceBase`` | ||
""" | ||
|
||
validator: "Validator" = lambda x: [] | ||
validator: "Validator" = lambda x: [] # noqa: E731 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also wasn't able to figure this one out |
||
"""A function that can validate a resource and return implicit dependencies. | ||
|
||
If called without a validator function, default to a function returning an empty Sequence | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get this one in parity, but might be fine?