[RSDK-3634] Implement data.proto APIs that Add/Remove Tags #334
Conversation
ghost
requested review from
|
@8ashar per this PR, |
There was a problem hiding this comment.
LGTM but I'm requesting that we change the user-facing API of the *_by_file_ids methods to instead be *_by_ids, and update the args/comments appropriately. The methods are changing name and we should fix the user-facing experience to match right away, then update the methods once the new protos go into effect.
See this pr for details.
Edit: in addition, we should change the actual argument structure. Right now we're passing file IDs (which are strings) into a deprecated file_id field that isn't looked at. What we should pass are BinaryIDs (which are a proto type BinaryID and which include, among other things, an optional file_id) into the binary_id field that is looked at.
src/viam/app/data/client.py
Outdated
| GRPCError: if no binary_ids or tags are provided | ||
| """ | ||
| request = AddTagsToBinaryDataByIDsRequest(binary_ids=binary_ids, tags=tags) | ||
| _: AddTagstoBinaryDataByIDsResponse = await self._data_client.AddTagsToBinaryDataByIDs(request, metadata=self._metadata) |
There was a problem hiding this comment.
oh tiny nit here, s/AddTagstoBinaryDataByIDsResponse/AddTags**T**oBinaryDataByIDsResponse
This PR implements and adds docstrings to the gRPC methods that'll allow a DataClient to send a gGRPC request to app to add, remove, and retrieve tags. The PR also implements a function to retrieve bounding box labels. There are a few other minor changes throughout. Namely, some function signatures are updated to include defaults for certain parameters (i.e. empty filter), and the AppClient "close()" function is implemented with logging.